qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 11/13] qapi2texi: De-duplicate code to add blank line before symbol
Date: Wed, 20 Dec 2017 19:59:22 +0100	[thread overview]
Message-ID: <20171220185924.32756-12-armbru@redhat.com> (raw)
In-Reply-To: <20171220185924.32756-1-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20171002141341.24616-12-armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 scripts/qapi2texi.py | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
index 58add26c11..92e2af2cd6 100755
--- a/scripts/qapi2texi.py
+++ b/scripts/qapi2texi.py
@@ -206,8 +206,6 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
 
     def visit_enum_type(self, name, info, values, prefix):
         doc = self.cur_doc
-        if self.out:
-            self.out += '\n'
         self.out += TYPE_FMT(type='Enum',
                              name=doc.symbol,
                              body=texi_entity(doc, 'Values',
@@ -217,16 +215,12 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
         doc = self.cur_doc
         if base and base.is_implicit():
             base = None
-        if self.out:
-            self.out += '\n'
         self.out += TYPE_FMT(type='Object',
                              name=doc.symbol,
                              body=texi_entity(doc, 'Members', base, variants))
 
     def visit_alternate_type(self, name, info, variants):
         doc = self.cur_doc
-        if self.out:
-            self.out += '\n'
         self.out += TYPE_FMT(type='Alternate',
                              name=doc.symbol,
                              body=texi_entity(doc, 'Members'))
@@ -234,8 +228,6 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
     def visit_command(self, name, info, arg_type, ret_type,
                       gen, success_response, boxed):
         doc = self.cur_doc
-        if self.out:
-            self.out += '\n'
         if boxed:
             body = texi_body(doc)
             body += ('\n@b{Arguments:} the members of @code{%s}\n'
@@ -249,13 +241,13 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
 
     def visit_event(self, name, info, arg_type, boxed):
         doc = self.cur_doc
-        if self.out:
-            self.out += '\n'
         self.out += MSG_FMT(type='Event',
                             name=doc.symbol,
                             body=texi_entity(doc, 'Arguments'))
 
     def symbol(self, doc, entity):
+        if self.out:
+            self.out += '\n'
         self.cur_doc = doc
         entity.visit(self)
         self.cur_doc = None
-- 
2.13.6

  parent reply	other threads:[~2017-12-20 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 18:59 [Qemu-devel] [PULL 00/13] QAPI patches for 2017-12-20 Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 01/13] qapi-schema: Fix query-vm-generation-id's doc comment markup Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 02/13] qapi: Stop rejecting #optional Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 03/13] qapi: Eliminate QAPISchemaParser.__init__()'s local fname Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 04/13] qapi: Make cur_doc local to QAPISchemaParser.__init__() Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 05/13] tests/qapi-schema/doc-bad-section: New, factored out of doc-good Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 06/13] qapi2texi: Clean up texi_sections() Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 07/13] qapi: Unify representation of doc section without name Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 08/13] qapi: Simplify representation of QAPIDoc section text Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 09/13] qapi2texi: Simplify representation of " Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 10/13] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section Markus Armbruster
2017-12-20 18:59 ` Markus Armbruster [this message]
2017-12-20 18:59 ` [Qemu-devel] [PULL 12/13] qapi-docs: fix a comment typo Markus Armbruster
2017-12-20 18:59 ` [Qemu-devel] [PULL 13/13] qmp: remove qmp_cpu Markus Armbruster
2017-12-20 22:17 ` [Qemu-devel] [PULL 00/13] QAPI patches for 2017-12-20 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220185924.32756-12-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).