From: Thomas Huth <huth@tuxfamily.org>
To: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] target/m68k: add monitor.c
Date: Wed, 20 Dec 2017 22:22:19 +0100 [thread overview]
Message-ID: <20171220222219.7cdf2a57@thl530> (raw)
In-Reply-To: <20171220203528.21334-1-laurent@vivier.eu>
Am Wed, 20 Dec 2017 21:35:28 +0100
schrieb Laurent Vivier <laurent@vivier.eu>:
> This allows to use registers content in the monitor.
>
> Example:
>
> BEFORE:
> (qemu) print $d0
> unknown register
>
> AFTER:
> (qemu) print $d0
> 0
> (qemu) print $sr
> 0x2000
> (qemu) x/10i $pc
> 0x40010a2a: movew %sr,%d0
> 0x40010a2c: oril #1792,%d0
> 0x40010a32: movew %d0,%sr
> 0x40010a34: movel %a0@,%d0
> 0x40010a36: btst #3,%d0
> 0x40010a3a: beqs 0x40010a26
> 0x40010a3c: movew %sr,%d0
> 0x40010a3e: andil #63743,%d0
> 0x40010a44: movew %d0,%sr
> 0x40010a46: rts
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/Makefile.objs | 1 +
> target/m68k/monitor.c | 55
> +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56
> insertions(+) create mode 100644 target/m68k/monitor.c
>
> diff --git a/target/m68k/Makefile.objs b/target/m68k/Makefile.objs
> index 39141ab93d..d143f20270 100644
> --- a/target/m68k/Makefile.objs
> +++ b/target/m68k/Makefile.objs
> @@ -1,3 +1,4 @@
> obj-y += m68k-semi.o
> obj-y += translate.o op_helper.o helper.o cpu.o fpu_helper.o
> obj-y += gdbstub.o
> +obj-$(CONFIG_SOFTMMU) += monitor.o
> diff --git a/target/m68k/monitor.c b/target/m68k/monitor.c
> new file mode 100644
> index 0000000000..03d037ccab
> --- /dev/null
> +++ b/target/m68k/monitor.c
> @@ -0,0 +1,55 @@
> +/*
> + * QEMU monitor
> + *
> + * Copyright (c) 2003-2004 Fabrice Bellard
Why this copyright line (and the non-GPL license code)?
Apart from that, the patch looks fine to me.
Thomas
next prev parent reply other threads:[~2017-12-20 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 20:35 [Qemu-devel] [PATCH] target/m68k: add monitor.c Laurent Vivier
2017-12-20 20:54 ` Philippe Mathieu-Daudé
2017-12-21 7:57 ` Laurent Vivier
2017-12-20 21:01 ` Richard Henderson
2017-12-20 21:22 ` Thomas Huth [this message]
2017-12-21 7:56 ` Laurent Vivier
2017-12-21 8:04 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220222219.7cdf2a57@thl530 \
--to=huth@tuxfamily.org \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).