From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRpmM-0007J3-1t for qemu-devel@nongnu.org; Wed, 20 Dec 2017 20:36:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRpmL-0001Vf-9e for qemu-devel@nongnu.org; Wed, 20 Dec 2017 20:36:10 -0500 From: Eric Blake Date: Wed, 20 Dec 2017 19:35:59 -0600 Message-Id: <20171221013600.17648-4-eblake@redhat.com> In-Reply-To: <20171221013600.17648-1-eblake@redhat.com> References: <20171221013600.17648-1-eblake@redhat.com> Subject: [Qemu-devel] [PULL 3/4] nbd/server: add additional assert to nbd_export_put List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , Paolo Bonzini , "open list:Network Block Dev..." From: Vladimir Sementsov-Ogievskiy This place is not obvious, nbd_export_close may theoretically reduce refcount to 0. It may happen if someone calls nbd_export_put on named export not through nbd_export_set_name when refcount is 1. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20171109154049.42386-2-vsementsov@virtuozzo.com> Signed-off-by: Eric Blake --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index e443b3cf5c..a6d7c24663 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1190,6 +1190,7 @@ void nbd_export_put(NBDExport *exp) nbd_export_close(exp); } + assert(exp->refcount > 0); if (--exp->refcount == 0) { assert(exp->name == NULL); assert(exp->description == NULL); -- 2.14.3