From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRoY4-0001LK-M8 for qemu-devel@nongnu.org; Wed, 20 Dec 2017 19:17:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRoY0-0001VT-NA for qemu-devel@nongnu.org; Wed, 20 Dec 2017 19:17:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53216) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRoY0-0001Ux-Gs for qemu-devel@nongnu.org; Wed, 20 Dec 2017 19:17:16 -0500 Date: Thu, 21 Dec 2017 02:17:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20171221021700-mutt-send-email-mst@kernel.org> References: <20171219033730.12748-1-haozhong.zhang@intel.com> <20171219033730.12748-3-haozhong.zhang@intel.com> <20171219163520.GA4836@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219163520.GA4836@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v3 2/2] target/i386: add clflushopt to "Skylake-Server" cpu model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Haozhong Zhang , qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson On Tue, Dec 19, 2017 at 02:35:20PM -0200, Eduardo Habkost wrote: > On Tue, Dec 19, 2017 at 11:37:30AM +0800, Haozhong Zhang wrote: > > CPUID_7_0_EBX_CLFLUSHOPT is missed in current "Skylake-Server" cpu > > model. Add it to "Skylake-Server" cpu model on pc-i440fx-2.12 and > > pc-q35-2.12. Keep it disabled in "Skylake-Server" cpu model on older > > machine types. > > > > Signed-off-by: Haozhong Zhang > > > Reviewed-by: Eduardo Habkost > > Michael, do you want to merge it through your tree as it needs > the pc-2.12 patch? Reviewed-by: Michael S. Tsirkin Please merge it ASAP. > > > --- > > include/hw/i386/pc.h | 5 +++++ > > target/i386/cpu.c | 2 +- > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > > index 83d825e896..bb49165fe0 100644 > > --- a/include/hw/i386/pc.h > > +++ b/include/hw/i386/pc.h > > @@ -323,6 +323,11 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > > > > #define PC_COMPAT_2_11 \ > > HW_COMPAT_2_11 \ > > + {\ > > + .driver = "Skylake-Server" "-" TYPE_X86_CPU,\ > > + .property = "clflushopt",\ > > + .value = "off",\ > > + }, > > > > #define PC_COMPAT_2_10 \ > > HW_COMPAT_2_10 \ > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 82603e3130..54574fa232 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -1376,7 +1376,7 @@ static X86CPUDefinition builtin_x86_defs[] = { > > CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_MPX | CPUID_7_0_EBX_CLWB | > > CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512DQ | > > CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512CD | > > - CPUID_7_0_EBX_AVX512VL, > > + CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT, > > /* Missing: XSAVES (not supported by some Linux versions, > > * including v4.1 to v4.12). > > * KVM doesn't yet expose any XSAVES state save component, > > -- > > 2.14.1 > > > > > > -- > Eduardo