From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRzQb-0001kX-5T for qemu-devel@nongnu.org; Thu, 21 Dec 2017 06:54:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRzQW-00050X-8i for qemu-devel@nongnu.org; Thu, 21 Dec 2017 06:54:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37632) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eRzQW-0004zh-1e for qemu-devel@nongnu.org; Thu, 21 Dec 2017 06:54:16 -0500 Date: Thu, 21 Dec 2017 19:54:07 +0800 From: Fam Zheng Message-ID: <20171221115407.GR10812@lemon> References: <20171219084557.9801-1-peterx@redhat.com> <20171219084557.9801-22-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171219084557.9801-22-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , Markus Armbruster , marcandre.lureau@redhat.com, "Dr . David Alan Gilbert" On Tue, 12/19 16:45, Peter Xu wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute": "command-that-allows-oob", > "arguments": { ... }, > "control": { "run-oob": true } } > > The "control" key is introduced to store this extra flag. "control" > field is used to store arguments that are shared by all the commands, > rather than command specific arguments. Let "run-oob" be the first. > > Signed-off-by: Peter Xu Reviewed-by: Fam Zheng