From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext
Date: Thu, 21 Dec 2017 15:22:34 +0100 [thread overview]
Message-ID: <20171221142251.18366-3-kwolf@redhat.com> (raw)
In-Reply-To: <20171221142251.18366-1-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
---
block/io.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/io.c b/block/io.c
index cf780c3cb0..b94740b8ff 100644
--- a/block/io.c
+++ b/block/io.c
@@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
BdrvNextIterator it;
GSList *aio_ctxs = NULL, *ctx;
+ /* BDRV_POLL_WHILE() for a node can only be called from its own I/O thread
+ * or the main loop AioContext. We potentially use BDRV_POLL_WHILE() on
+ * nodes in several different AioContexts, so make sure we're in the main
+ * context. */
+ assert(qemu_get_current_aio_context() == qemu_get_aio_context());
+
block_job_pause_all();
for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
--
2.13.6
next prev parent reply other threads:[~2017-12-21 14:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 14:22 [Qemu-devel] [PATCH v2 00/19] Drain fixes and cleanups, part 2 Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 01/19] block: Remove unused bdrv_requests_pending Kevin Wolf
2018-01-03 16:09 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-12-21 14:22 ` Kevin Wolf [this message]
2018-01-08 16:09 ` [Qemu-devel] [Qemu-block] [PATCH v2 02/19] block: Assert drain_all is only called from main AioContext Alberto Garcia
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 03/19] block: Make bdrv_drain() driver callbacks non-recursive Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 04/19] test-bdrv-drain: Test callback for bdrv_drain Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 05/19] test-bdrv-drain: Test bs->quiesce_counter Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 06/19] blockjob: Pause job on draining any job BDS Kevin Wolf
2018-01-08 14:44 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 07/19] test-bdrv-drain: Test drain vs. block jobs Kevin Wolf
2018-01-08 15:21 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 08/19] block: Don't block_job_pause_all() in bdrv_drain_all() Kevin Wolf
2018-01-08 15:15 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 09/19] block: Nested drain_end must still call callbacks Kevin Wolf
2018-01-08 15:41 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-01-08 18:00 ` Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 10/19] test-bdrv-drain: Test nested drain sections Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 11/19] block: Don't notify parents in drain call chain Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 12/19] block: Add bdrv_subtree_drained_begin/end() Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 13/19] test-bdrv-drain: Tests for bdrv_subtree_drain Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 14/19] test-bdrv-drain: Test behaviour in coroutine context Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 15/19] test-bdrv-drain: Recursive draining with multiple parents Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 16/19] block: Allow graph changes in subtree drained section Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 17/19] test-bdrv-drain: Test graph changes in " Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 18/19] commit: Simplify reopen of base Kevin Wolf
2017-12-21 14:22 ` [Qemu-devel] [PATCH v2 19/19] block: Keep nodes drained between reopen_queue/multiple Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221142251.18366-3-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).