qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com,
	mlureau@redhat.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask
Date: Thu, 21 Dec 2017 22:21:21 +0100	[thread overview]
Message-ID: <20171221212125.19075-2-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20171221212125.19075-1-maxime.coquelin@redhat.com>

VIRTIO_NET_F_MAC is a bit position, not a bit mask.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 tests/vhost-user-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index e2c89ed376..43c6528644 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -177,7 +177,7 @@ static void init_virtio_dev(TestServer *s)
     qvirtio_set_driver(&dev->vdev);
 
     features = qvirtio_get_features(&dev->vdev);
-    features = features & VIRTIO_NET_F_MAC;
+    features = features & (1u << VIRTIO_NET_F_MAC);
     qvirtio_set_features(&dev->vdev, features);
 
     qvirtio_set_driver_ok(&dev->vdev);
-- 
2.14.3

  reply	other threads:[~2017-12-21 21:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 21:21 [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up Maxime Coquelin
2017-12-21 21:21 ` Maxime Coquelin [this message]
2017-12-22 13:41   ` [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 2/5] vhost-user-test: extract read-guest-mem test from main loop Maxime Coquelin
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 3/5] vhost-user-test: setup virtqueues in all tests Maxime Coquelin
2017-12-22 13:51   ` Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 4/5] vhost-user-test: make features mask an init_virtio_dev() argument Maxime Coquelin
2017-12-22 13:50   ` Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 5/5] vhost-user-test: use init_virtio_dev in multiqueue test Maxime Coquelin
2017-12-22 13:52   ` Marc-André Lureau
2017-12-21 21:48 ` [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up no-reply
2017-12-21 22:49 ` Michael S. Tsirkin
2017-12-22  8:31   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221212125.19075-2-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).