qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mlureau@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up
Date: Fri, 22 Dec 2017 00:49:55 +0200	[thread overview]
Message-ID: <20171222004937-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171221212125.19075-1-maxime.coquelin@redhat.com>

On Thu, Dec 21, 2017 at 10:21:20PM +0100, Maxime Coquelin wrote:
> Sorry, I missed to fixup the feature mask in patch 4,
> this is the only change in this v3.
> 
> The two changes in v2 are fixing the features mask
> before the function rework, and reword of commit message
> of patch "vhost-user-test: extract read-guest-mem test
> from main loop" (Thanks Marc-André).
> 
> This series fixes two issues in vhost-user-test:
> 1. Setup virtqueues in all tests
> 2. Fix features mask for all but test_multiqueue()
> 
> The clean-ups comprises making read-guest-mem test consistent
> with other tests by initializing the device in the qtest thread.
> Also, some code factorization is done with regard to device
> initialization so that all tests share the same init.

Looks like mingw tests fail with this.

> Maxime Coquelin (5):
>   vhost-user-test: fix features mask
>   vhost-user-test: extract read-guest-mem test from main loop
>   vhost-user-test: setup virtqueues in all tests
>   vhost-user-test: make features mask an init_virtio_dev() argument
>   vhost-user-test: use init_virtio_dev in multiqueue test
> 
>  tests/vhost-user-test.c | 171 ++++++++++++++++++++++--------------------------
>  1 file changed, 79 insertions(+), 92 deletions(-)
> 
> -- 
> 2.14.3

  parent reply	other threads:[~2017-12-21 22:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 21:21 [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up Maxime Coquelin
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 1/5] vhost-user-test: fix features mask Maxime Coquelin
2017-12-22 13:41   ` Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 2/5] vhost-user-test: extract read-guest-mem test from main loop Maxime Coquelin
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 3/5] vhost-user-test: setup virtqueues in all tests Maxime Coquelin
2017-12-22 13:51   ` Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 4/5] vhost-user-test: make features mask an init_virtio_dev() argument Maxime Coquelin
2017-12-22 13:50   ` Marc-André Lureau
2017-12-21 21:21 ` [Qemu-devel] [PATCH v3 5/5] vhost-user-test: use init_virtio_dev in multiqueue test Maxime Coquelin
2017-12-22 13:52   ` Marc-André Lureau
2017-12-21 21:48 ` [Qemu-devel] [PATCH v3 0/5] vhost-user-test: Fixes & code clean-up no-reply
2017-12-21 22:49 ` Michael S. Tsirkin [this message]
2017-12-22  8:31   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222004937-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).