From: Kevin Wolf <kwolf@redhat.com>
To: Jack Schwartz <jack.schwartz@oracle.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com,
armbru@redhat.com, eblake@redhat.com, karl.heubaum@oracle.com,
konrad.wilk@oracle.com
Subject: Re: [Qemu-devel] [PATCH v1 1/1] block: Add numeric errno field to BLOCK_IO_ERROR events
Date: Fri, 22 Dec 2017 14:52:08 +0100 [thread overview]
Message-ID: <20171222135208.GI3763@localhost.localdomain> (raw)
In-Reply-To: <1513901496-13538-2-git-send-email-jack.schwartz@oracle.com>
Am 22.12.2017 um 01:11 hat Jack Schwartz geschrieben:
> BLOCK_IO_ERROR events currently contain a "reason" string which is
> strerror(errno) of the error. This enhancement provides those events with
> the numeric errno value as well, since it is easier to parse for error type
> than a string.
>
> Signed-off-by: Jack Schwartz <jack.schwartz@oracle.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
Apart from the technical details that Eric mentioed, I wonder what is
your use case for this?
Exposing errors in a machine readable form was discussed earlier, and
the result was that nobody had an actual use for error codes other than
presenting the right error message to the user - which the error string
already achieves.
The only exception so far was ENOSPC, which some management tools like
oVirt respond to by increasing the volume size, so this was mapped into
a bool.
Kevin
next prev parent reply other threads:[~2017-12-22 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 0:11 [Qemu-devel] [PATCH v1 0/1] block: Add numeric errno field to BLOCK_IO_ERROR events Jack Schwartz
2017-12-22 0:11 ` [Qemu-devel] [PATCH v1 1/1] " Jack Schwartz
2017-12-22 1:08 ` Eric Blake
2017-12-22 1:15 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-12-22 13:52 ` Kevin Wolf [this message]
2018-01-08 19:57 ` [Qemu-devel] " Jack Schwartz
2018-01-09 10:24 ` Kevin Wolf
2018-01-10 21:28 ` Jack Schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222135208.GI3763@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jack.schwartz@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).