From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTIyn-0001rt-Bf for qemu-devel@nongnu.org; Sun, 24 Dec 2017 21:59:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTIyj-0001e1-Fs for qemu-devel@nongnu.org; Sun, 24 Dec 2017 21:59:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59602) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eTIyj-0001bc-9Y for qemu-devel@nongnu.org; Sun, 24 Dec 2017 21:59:01 -0500 Date: Mon, 25 Dec 2017 10:58:47 +0800 From: Peter Xu Message-ID: <20171225025847.GA2443@xz-mi> References: <20171219084557.9801-1-peterx@redhat.com> <20171219084557.9801-2-peterx@redhat.com> <20171220164005.GH12566@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171220164005.GH12566@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [RFC v6 01/27] chardev: use backend chr context when watch for fe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Daniel P . Berrange" , Paolo Bonzini , Fam Zheng , Juan Quintela , mdroth@linux.vnet.ibm.com, Eric Blake , Laurent Vivier , Markus Armbruster , marcandre.lureau@redhat.com, "Dr . David Alan Gilbert" On Wed, Dec 20, 2017 at 04:40:05PM +0000, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:31PM +0800, Peter Xu wrote: > > In commit 6bbb6c0644 ("chardev: use per-dev context for > > io_add_watch_poll", 2017-09-22) all the chardev watches are converted to > > use per-chardev gcontext to support chardev to be run outside default > > main thread. However that's still missing one call from the frontend > > code. Touch that up. > > > > Signed-off-by: Peter Xu > > --- > > chardev/char-fe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/chardev/char-fe.c b/chardev/char-fe.c > > index ee6d596100..462c529f19 100644 > > --- a/chardev/char-fe.c > > +++ b/chardev/char-fe.c > > @@ -356,7 +356,7 @@ guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition cond, > > } > > > > g_source_set_callback(src, (GSourceFunc)func, user_data, NULL); > > - tag = g_source_attach(src, NULL); > > + tag = g_source_attach(src, be->chr->gcontext); > > If you respin, it's a little nicer to use the s local variable instead: > > tag = g_source_attach(src, s->gcontext); Definitely. R-b is taken as well. Thanks, -- Peter Xu