From: Fam Zheng <famz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, kwolf@redhat.com,
peter.maydell@linaro.org, lirans@il.ibm.com, quintela@redhat.com,
jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, den@openvz.org, amit.shah@redhat.com,
pbonzini@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v9 12/13] iotests: add dirty bitmap migration test
Date: Thu, 28 Dec 2017 14:28:10 +0800 [thread overview]
Message-ID: <20171228062810.GK9192@lemon> (raw)
In-Reply-To: <20171220154945.88410-13-vsementsov@virtuozzo.com>
On Wed, 12/20 18:49, Vladimir Sementsov-Ogievskiy wrote:
> +def inject_test_case(klass, name, method, *args, **kwargs):
> + mc = operator.methodcaller(method, *args, **kwargs)
> + setattr(klass, 'test_' + name, new.instancemethod(mc, None, klass))
> +
> +
> +for cmb in list(itertools.product((True, False), repeat=4)):
> + name = ('_' if cmb[0] else '_not_') + 'persistent_'
> + name += ('_' if cmb[1] else '_not_') + 'shared_'
> + name += ('_' if cmb[2] else '_not_') + 'migbitmap_'
> + name += '_online' if cmb[3] else '_offline'
> +
> + inject_test_case(TestDirtyBitmapMigration, name, 'do_test_migration', *cmb)
Personally I'd just spell out the 16 method names and call do_test_migration.
It's much easier to read and modify. Either way,
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-12-28 6:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 15:49 [Qemu-devel] [PATCH v9 00/13] Dirty bitmaps postcopy migration Vladimir Sementsov-Ogievskiy
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 01/13] block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() Vladimir Sementsov-Ogievskiy
2017-12-28 5:16 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 02/13] block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-12-28 5:20 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-12-28 5:24 ` Fam Zheng
2017-12-28 11:16 ` Vladimir Sementsov-Ogievskiy
2017-12-29 1:31 ` Fam Zheng
2018-01-18 8:43 ` Paolo Bonzini
2018-01-18 9:55 ` Vladimir Sementsov-Ogievskiy
2018-01-18 10:09 ` Paolo Bonzini
2018-01-19 14:12 ` Vladimir Sementsov-Ogievskiy
2018-01-22 12:14 ` Vladimir Sementsov-Ogievskiy
2018-01-22 17:50 ` John Snow
2018-01-24 10:16 ` Paolo Bonzini
2018-01-24 22:29 ` John Snow
2018-02-06 14:53 ` Vladimir Sementsov-Ogievskiy
2018-02-12 17:30 ` Vladimir Sementsov-Ogievskiy
2018-02-13 7:45 ` Paolo Bonzini
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 04/13] dirty-bitmap: add locked state Vladimir Sementsov-Ogievskiy
2017-12-22 2:03 ` John Snow
2017-12-22 9:37 ` Vladimir Sementsov-Ogievskiy
2017-12-22 8:46 ` Vladimir Sementsov-Ogievskiy
2017-12-28 5:32 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 05/13] migration: introduce postcopy-only pending Vladimir Sementsov-Ogievskiy
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 06/13] qapi: add dirty-bitmaps migration capability Vladimir Sementsov-Ogievskiy
2017-12-28 5:41 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 07/13] migration: include migrate_dirty_bitmaps in migrate_postcopy Vladimir Sementsov-Ogievskiy
2017-12-28 5:42 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 08/13] migration/qemu-file: add qemu_put_counted_string() Vladimir Sementsov-Ogievskiy
2017-12-28 5:48 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 09/13] migration: add is_active_iterate handler Vladimir Sementsov-Ogievskiy
2017-12-28 5:50 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 10/13] migration: add postcopy migration of dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-12-28 6:14 ` Fam Zheng
2017-12-28 11:47 ` Vladimir Sementsov-Ogievskiy
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 11/13] iotests: add default node-name Vladimir Sementsov-Ogievskiy
2017-12-28 6:15 ` Fam Zheng
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 12/13] iotests: add dirty bitmap migration test Vladimir Sementsov-Ogievskiy
2017-12-28 6:28 ` Fam Zheng [this message]
2017-12-20 15:49 ` [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test Vladimir Sementsov-Ogievskiy
2017-12-28 6:33 ` Fam Zheng
2017-12-28 11:49 ` Vladimir Sementsov-Ogievskiy
2018-01-17 18:30 ` John Snow
2018-01-18 9:57 ` Vladimir Sementsov-Ogievskiy
2018-01-19 18:08 ` Vladimir Sementsov-Ogievskiy
2018-01-19 18:20 ` John Snow
2018-01-20 0:37 ` John Snow
2018-01-22 9:06 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228062810.GK9192@lemon \
--to=famz@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lirans@il.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).