From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUSde-0001Cu-8c for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUSdd-0005DF-D8 for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58632) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eUSdd-0005Cv-7c for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:01 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 64BD2A799 for ; Thu, 28 Dec 2017 07:30:00 +0000 (UTC) From: Peter Xu Date: Thu, 28 Dec 2017 15:29:43 +0800 Message-Id: <20171228072945.9573-2-peterx@redhat.com> In-Reply-To: <20171228072945.9573-1-peterx@redhat.com> References: <20171228072945.9573-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] chardev: use backend chr context when watch for fe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , peterx@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= In commit 6bbb6c0644 ("chardev: use per-dev context for io_add_watch_poll", 2017-09-22) all the chardev watches are converted to use per-chardev gcontext to support chardev to be run outside default main thread. However that's still missing one call from the frontend code. Touch that up. Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Xu --- chardev/char-fe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-fe.c b/chardev/char-fe.c index ee6d596100..c611b3fa3e 100644 --- a/chardev/char-fe.c +++ b/chardev/char-fe.c @@ -356,7 +356,7 @@ guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition cond, } g_source_set_callback(src, (GSourceFunc)func, user_data, NULL); - tag = g_source_attach(src, NULL); + tag = g_source_attach(src, s->gcontext); g_source_unref(src); return tag; -- 2.14.3