From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUSdq-0001OS-Oz for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUSdn-0005Tp-Kf for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46590) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eUSdn-0005S3-Et for qemu-devel@nongnu.org; Thu, 28 Dec 2017 02:30:11 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACB305D698 for ; Thu, 28 Dec 2017 07:30:10 +0000 (UTC) From: Peter Xu Date: Thu, 28 Dec 2017 15:29:44 +0800 Message-Id: <20171228072945.9573-3-peterx@redhat.com> In-Reply-To: <20171228072945.9573-1-peterx@redhat.com> References: <20171228072945.9573-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] chardev: let g_idle_add() be with chardev gcontext List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Stefan Hajnoczi , peterx@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= The idle task will be attached to main gcontext even if the chardev backend is running in another gcontext. Fix the only caller by extending the g_idle_add() logic into the more powerful g_source_attach(). It's basically g_idle_add_full() implementation, but with the chardev's gcontext passed in. Signed-off-by: Peter Xu --- chardev/char-pty.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 761ae6dec1..dd17b1b823 100644 --- a/chardev/char-pty.c +++ b/chardev/char-pty.c @@ -210,9 +210,14 @@ static void pty_chr_state(Chardev *chr, int connected) s->timer_tag = 0; } if (!s->connected) { + GSource *source = g_idle_source_new(); + g_assert(s->open_tag == 0); s->connected = 1; - s->open_tag = g_idle_add(qemu_chr_be_generic_open_func, chr); + g_source_set_callback(source, qemu_chr_be_generic_open_func, + chr, NULL); + s->open_tag = g_source_attach(source, chr->gcontext); + g_source_unref(source); } if (!chr->gsource) { chr->gsource = io_add_watch_poll(chr, s->ioc, -- 2.14.3