From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUkjT-0001kp-3p for qemu-devel@nongnu.org; Thu, 28 Dec 2017 21:49:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUkjS-0001Qv-GG for qemu-devel@nongnu.org; Thu, 28 Dec 2017 21:49:15 -0500 Date: Fri, 29 Dec 2017 10:49:01 +0800 From: Fam Zheng Message-ID: <20171229024901.GF13004@lemon> References: <20171207203036.14993-1-eblake@redhat.com> <20171207203036.14993-6-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207203036.14993-6-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 05/20] iscsi: Switch cluster_sectors to byte-based List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, vsementsov@virtuozzo.com, Ronnie Sahlberg , Paolo Bonzini , Peter Lieven , Max Reitz On Thu, 12/07 14:30, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert all uses of > the cluster size in sectors, along with adding assertions that we > are not dividing by zero. > > Improve some comment grammar while in the area. > > Signed-off-by: Eric Blake > Acked-by: Paolo Bonzini Reviewed-by: Fam Zheng