From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50090)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1eUlA7-0004Ne-Tx
	for qemu-devel@nongnu.org; Thu, 28 Dec 2017 22:16:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1eUlA6-0002Sz-Vb
	for qemu-devel@nongnu.org; Thu, 28 Dec 2017 22:16:47 -0500
Date: Fri, 29 Dec 2017 11:16:39 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20171229031639.GP13004@lemon>
References: <20171207203036.14993-1-eblake@redhat.com>
	<20171207203036.14993-18-eblake@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171207203036.14993-18-eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 17/20] vmdk: Switch to
 .bdrv_co_block_status()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, vsementsov@virtuozzo.com, Max Reitz <mreitz@redhat.com>

On Thu, 12/07 14:30, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based.  Update the vmdk driver accordingly.  Drop the
> now-unused vmdk_find_index_in_cluster().
> 
> Also, fix a pre-existing bug: if find_extent() fails (unlikely,
> since the block layer did a bounds check), then we must return a
> failure, rather than 0.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>