From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eUlE6-0005iI-Hd for qemu-devel@nongnu.org; Thu, 28 Dec 2017 22:20:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eUlE5-0008Dd-LX for qemu-devel@nongnu.org; Thu, 28 Dec 2017 22:20:54 -0500 Date: Fri, 29 Dec 2017 11:20:46 +0800 From: Fam Zheng Message-ID: <20171229032046.GQ13004@lemon> References: <20171207203036.14993-1-eblake@redhat.com> <20171207203036.14993-8-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207203036.14993-8-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 07/20] iscsi: Switch to .bdrv_co_block_status() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, vsementsov@virtuozzo.com, Ronnie Sahlberg , Paolo Bonzini , Peter Lieven , Max Reitz On Thu, 12/07 14:30, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the iscsi driver accordingly. In this case, > it is handy to teach iscsi_co_block_status() to handle a NULL map > and file parameter, even though the block layer passes non-NULL > values, because we also call the function directly. For now, there > are no optimizations done based on the want_zero flag. > > We can also make the simplification of asserting that the block > layer passed in aligned values. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng