qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 2/8] target/moxie: Fix tlb_fill
Date: Fri, 29 Dec 2017 11:31:07 -0800	[thread overview]
Message-ID: <20171229193113.11753-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20171229193113.11753-1-richard.henderson@linaro.org>

We should not exit unless moxie_cpu_handle_mmu_fault has failed.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/moxie/helper.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/moxie/helper.c b/target/moxie/helper.c
index 2ecee89f11..6890ffd71c 100644
--- a/target/moxie/helper.c
+++ b/target/moxie/helper.c
@@ -36,9 +36,8 @@ void tlb_fill(CPUState *cs, target_ulong addr, MMUAccessType access_type,
 
     ret = moxie_cpu_handle_mmu_fault(cs, addr, access_type, mmu_idx);
     if (unlikely(ret)) {
-        cpu_restore_state(cs, retaddr);
+        cpu_loop_exit_restore(cs, retaddr);
     }
-    cpu_loop_exit(cs);
 }
 
 void helper_raise_exception(CPUMoxieState *env, int ex)
-- 
2.14.3

  parent reply	other threads:[~2017-12-29 19:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 19:31 [Qemu-devel] [PULL 0/8] tcg queued patches Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 1/8] target/*helper: don't check retaddr before calling cpu_restore_state Richard Henderson
2017-12-29 19:31 ` Richard Henderson [this message]
2017-12-29 19:31 ` [Qemu-devel] [PULL 3/8] tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED* Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 4/8] tcg: Dynamically allocate TCGOps Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 5/8] tcg: Generalize TCGOp parameters Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 6/8] tcg: Add tcg_signed_cond Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 7/8] tcg: Allow 6 arguments to TCG helpers Richard Henderson
2017-12-29 19:31 ` [Qemu-devel] [PULL 8/8] tcg: add cs_base and flags to -d exec output Richard Henderson
2017-12-29 20:01 ` [Qemu-devel] [PULL 0/8] tcg queued patches no-reply
2017-12-29 20:02 ` no-reply
2017-12-29 20:17 ` no-reply
2017-12-29 20:56 ` [Qemu-devel] [PULL v2 " Richard Henderson
2018-01-08 21:01   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171229193113.11753-3-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).