From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: groug@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
lvivier@redhat.com, David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 13/15] spapr_pci: use warn_report()
Date: Wed, 3 Jan 2018 15:24:17 +1100 [thread overview]
Message-ID: <20180103042419.14520-14-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180103042419.14520-1-david@gibson.dropbear.id.au>
From: Greg Kurz <groug@kaod.org>
These two are definitely warnings. Let's use the appropriate API.
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr_pci.c | 6 +++---
hw/ppc/spapr_pci_vfio.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 88797b3d36..695c820911 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1696,9 +1696,9 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
/* DMA setup */
if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
&& kvm_enabled()) {
- error_report("System page size 0x%lx is not enabled in page_size_mask "
- "(0x%"PRIx64"). Performance may be slow",
- qemu_getrampagesize(), sphb->page_size_mask);
+ warn_report("System page size 0x%lx is not enabled in page_size_mask "
+ "(0x%"PRIx64"). Performance may be slow",
+ qemu_getrampagesize(), sphb->page_size_mask);
}
for (i = 0; i < windows_supported; ++i) {
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index 8448e0b024..1f775ea93d 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -50,7 +50,7 @@ static Property spapr_phb_vfio_properties[] = {
static void spapr_phb_vfio_instance_init(Object *obj)
{
if (!qtest_enabled()) {
- error_report("spapr-pci-vfio-host-bridge is deprecated");
+ warn_report("spapr-pci-vfio-host-bridge is deprecated");
}
}
--
2.14.3
next prev parent reply other threads:[~2018-01-03 4:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 4:24 [Qemu-devel] [PULL 00/15] ppc-for-2.12 queue 20180103 David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 01/15] target-ppc: optimize cmp translation David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 02/15] pseries: Update SLOF firmware image to qemu-slof-20171214 David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 03/15] sm501: Add panel hardware cursor registers also to read function David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 04/15] sm501: Add some more unimplemented registers David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 05/15] ppc4xx_i2c: Implement basic I2C functions David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 06/15] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 07/15] spapr: Capabilities infrastructure David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 08/15] spapr: Treat Hardware Transactional Memory (HTM) as an optional capability David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 09/15] spapr: Validate capabilities on migration David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 10/15] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 11/15] spapr: Handle VMX/VSX presence as an spapr capability flag David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 12/15] spapr: Handle Decimal Floating Point (DFP) as an optional capability David Gibson
2018-01-03 4:24 ` David Gibson [this message]
2018-01-03 4:24 ` [Qemu-devel] [PULL 14/15] hw/ide: Emulate SiI3112 SATA controller David Gibson
2018-01-03 4:24 ` [Qemu-devel] [PULL 15/15] target/ppc: more use of the PPC_*() macros David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103042419.14520-14-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).