From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] chardev: let g_idle_add() be with chardev gcontext
Date: Wed, 3 Jan 2018 17:41:58 +0000 [thread overview]
Message-ID: <20180103174158.GD21894@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180103021456.22526-3-peterx@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 636 bytes --]
On Wed, Jan 03, 2018 at 10:14:55AM +0800, Peter Xu wrote:
> The idle task will be attached to main gcontext even if the chardev
> backend is running in another gcontext. Fix the only caller by
> extending the g_idle_add() logic into the more powerful
> g_source_attach(). It's basically g_idle_add_full() implementation, but
> with the chardev's gcontext passed in.
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> chardev/char-pty.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-01-03 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 2:14 [Qemu-devel] [PATCH v2 0/3] chardev: convert leftover glib APIs to use dedicate gcontext Peter Xu
2018-01-03 2:14 ` [Qemu-devel] [PATCH v2 1/3] chardev: use backend chr context when watch for fe Peter Xu
2018-01-03 2:14 ` [Qemu-devel] [PATCH v2 2/3] chardev: let g_idle_add() be with chardev gcontext Peter Xu
2018-01-03 17:41 ` Stefan Hajnoczi [this message]
2018-01-03 2:14 ` [Qemu-devel] [PATCH v2 3/3] chardev: introduce qemu_chr_timeout_add() and use Peter Xu
2018-01-03 2:24 ` [Qemu-devel] [PATCH v2.1 " Peter Xu
2018-01-03 10:12 ` Marc-André Lureau
2018-01-03 17:41 ` Stefan Hajnoczi
2018-01-04 2:31 ` Peter Xu
2018-01-04 9:57 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103174158.GD21894@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).