From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Thomas Huth <huth@tuxfamily.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH v7 02/17] target/m68k: fix gen_get_ccr()
Date: Thu, 4 Jan 2018 02:28:58 +0100 [thread overview]
Message-ID: <20180104012913.30763-3-laurent@vivier.eu> (raw)
In-Reply-To: <20180104012913.30763-1-laurent@vivier.eu>
As gen_helper_get_ccr() is able to compute CCR from cc_op and
flags, we don't need to flush flags before to call it.
flush_flags() and get_ccr() use COMPUTE_CCR() to compute
flags. get_ccr() computes CCR value,
whereas flush_flags update live cc_op and flags.
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 0e9d651a2a..1e9fb01252 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -2478,7 +2478,6 @@ static TCGv gen_get_ccr(DisasContext *s)
{
TCGv dest;
- gen_flush_flags(s);
update_cc_op(s);
dest = tcg_temp_new();
gen_helper_get_ccr(dest, cpu_env);
--
2.14.3
next prev parent reply other threads:[~2018-01-04 1:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 1:28 [Qemu-devel] [PATCH v7 00/17] target/m68k: supervisor mode (part 1) Laurent Vivier
2018-01-04 1:28 ` [Qemu-devel] [PATCH v7 01/17] target-m68k: sync CC_OP before gen_jmp_tb() Laurent Vivier
2018-01-04 1:28 ` Laurent Vivier [this message]
2018-01-04 1:28 ` [Qemu-devel] [PATCH v7 03/17] linux-user, m68k: correctly manage SR in context Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 04/17] target/m68k: use insn_pc to generate instruction fault address Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 05/17] target/m68k: add CPU_LOG_INT trace Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 06/17] target/m68k: manage 680x0 stack frames Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 07/17] target/m68k: add chk and chk2 Laurent Vivier
2018-01-04 7:10 ` Richard Henderson
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 08/17] target/m68k: add move16 Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 09/17] target/m68k: softmmu cleanup Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 10/17] target/m68k: add cpush/cinv Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 11/17] target/m68k: add reset Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 12/17] target/m68k: implement fsave/frestore Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 13/17] target/m68k: move CCR/SR functions Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 14/17] target/m68k: add 680x0 "move to SR" instruction Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 15/17] target/m68k: add andi/ori/eori to SR/CCR Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 16/17] target/m68k: add the Interrupt Stack Pointer Laurent Vivier
2018-01-04 1:29 ` [Qemu-devel] [PATCH v7 17/17] target/m68k: fix m68k_cpu_dump_state() Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104012913.30763-3-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=huth@tuxfamily.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).