From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
peterx@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/3] chardev: convert leftover glib APIs to use dedicate gcontext
Date: Thu, 4 Jan 2018 18:43:33 +0800 [thread overview]
Message-ID: <20180104104336.2794-1-peterx@redhat.com> (raw)
v3:
- rename function to qemu_chr_timeout_add_ms() [Stefan]
- add comment on return code [Stefan]
- add comment in commit message on why change GSource name [Stefan]
v2:
- add r-bs
- fix patch 3 on some s->ms conversion [Marc-André]
There were existing work that tried to allow chardev to be run in a
dedicated gcontext rather than the default main context/thread.
Basically that work passed in the correct gcontext during
g_source_attach(). However, I found something missing along the way,
that some legacy glib APIs are used by chardev code which take the
main context as default:
g_timeout_add_seconds
g_timeout_add
g_idle_add
To fully allow the chardevs to be run in dedicated gcontext, we need
to convert all these legacy APIs into g_source_attach() calls as well,
with the correct gcontext passed in.
This series tries to clean the rest of things up.
I picked up patch 1 from monitor-oob series into this series (which is
a missing of chardev frontend call fix for g_source_attach()), so that
this series can be a complete fix.
Please review. Thanks,
Peter Xu (3):
chardev: use backend chr context when watch for fe
chardev: let g_idle_add() be with chardev gcontext
chardev: introduce qemu_chr_timeout_add_ms()
chardev/char-fe.c | 2 +-
chardev/char-pty.c | 16 ++++++++--------
chardev/char-socket.c | 6 ++++--
chardev/char.c | 21 +++++++++++++++++++++
hw/char/terminal3270.c | 7 ++++---
include/chardev/char.h | 3 +++
6 files changed, 41 insertions(+), 14 deletions(-)
--
2.14.3
next reply other threads:[~2018-01-04 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 10:43 Peter Xu [this message]
2018-01-04 10:43 ` [Qemu-devel] [PATCH v3 1/3] chardev: use backend chr context when watch for fe Peter Xu
2018-01-04 10:43 ` [Qemu-devel] [PATCH v3 2/3] chardev: let g_idle_add() be with chardev gcontext Peter Xu
2018-01-04 10:43 ` [Qemu-devel] [PATCH v3 3/3] chardev: introduce qemu_chr_timeout_add_ms() Peter Xu
2018-01-04 13:09 ` [Qemu-devel] [PATCH v3 0/3] chardev: convert leftover glib APIs to use dedicate gcontext Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104104336.2794-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).