From: Keith Busch <keith.busch@intel.com>
To: Hikaru Nishida <hikarupsp@gmail.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:nvme" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe
Date: Thu, 4 Jan 2018 11:20:48 -0700 [thread overview]
Message-ID: <20180104182048.GA7169@localhost.localdomain> (raw)
In-Reply-To: <1513573243-29022-1-git-send-email-hikarupsp@gmail.com>
On Mon, Dec 18, 2017 at 02:00:43PM +0900, Hikaru Nishida wrote:
> Pin-based interrupt of NVMe controller did not work properly
> because using an obsolated function pci_irq_pulse().
> To fix this, change to use pci_irq_assert() / pci_irq_deassert()
> instead of pci_irq_pulse().
Looks good. Thanks for the patch, and sorry for the delay.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2018-01-04 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 5:00 [Qemu-devel] [PATCH] hw/block: Fix pin-based interrupt behaviour of NVMe Hikaru Nishida
2017-12-22 7:31 ` Hikaru Nishida
2018-01-04 18:06 ` Hikaru Nishida
2018-01-04 18:20 ` Keith Busch [this message]
2018-01-08 15:28 ` Kevin Wolf
2018-01-09 0:38 ` Hikaru Nishida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104182048.GA7169@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hikarupsp@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).