qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration
Date: Fri,  5 Jan 2018 22:52:38 +0100	[thread overview]
Message-ID: <20180105215246.908-4-quintela@redhat.com> (raw)
In-Reply-To: <20180105215246.908-1-quintela@redhat.com>

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/migration-test.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 32f3bb86a8..d81f22118b 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -434,27 +434,29 @@ static void test_migrate_start(QTestState **from, QTestState **to,
     gchar *cmd_src, *cmd_dst;
     char *bootpath = g_strdup_printf("%s/bootsect", tmpfs);
     const char *arch = qtest_get_arch();
+    const char *accel = "kvm:tcg";
 
     got_stop = false;
 
     if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
         init_bootfile_x86(bootpath);
-        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
+        cmd_src = g_strdup_printf("-machine accel=%s -m 150M"
                                   " -name pcsource,debug-threads=on"
                                   " -serial file:%s/src_serial"
                                   " -drive file=%s,format=raw",
-                                  tmpfs, bootpath);
-        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
+                                  accel, tmpfs, bootpath);
+        cmd_dst = g_strdup_printf("-machine accel=%s -m 150M"
                                   " -name pcdest,debug-threads=on"
                                   " -serial file:%s/dest_serial"
                                   " -drive file=%s,format=raw"
                                   " -incoming %s",
-                                  tmpfs, bootpath, uri);
+                                  accel, tmpfs, bootpath, uri);
     } else if (strcmp(arch, "ppc64") == 0) {
-        const char *accel;
 
         /* On ppc64, the test only works with kvm-hv, but not with kvm-pr */
-        accel = access("/sys/module/kvm_hv", F_OK) ? "tcg" : "kvm:tcg";
+        if (access("/sys/module/kvm_hv", F_OK)) {
+            accel = "tcg";
+        }
         init_bootfile_ppc(bootpath);
         cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
                                   " -name pcsource,debug-threads=on"
-- 
2.14.3

  parent reply	other threads:[~2018-01-05 21:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 21:52 [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 01/11] tests: Remove deprecated migration tests commands Juan Quintela
2018-01-11 12:48   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments Juan Quintela
2018-01-10  6:25   ` Peter Xu
2018-01-10  8:47     ` Juan Quintela
2018-01-10  9:21       ` Laurent Vivier
2018-01-10 10:12         ` Laurent Vivier
2018-01-10 10:43           ` Juan Quintela
2018-01-10 11:03             ` Laurent Vivier
2018-01-05 21:52 ` Juan Quintela [this message]
2018-01-11 19:00   ` [Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration Juan Quintela
2018-01-10  6:30   ` Peter Xu
2018-01-10  8:43     ` Juan Quintela
2018-01-10  8:54       ` Peter Xu
2018-01-10 11:49         ` Dr. David Alan Gilbert
2018-01-10 14:58           ` Juan Quintela
2018-01-10 11:49   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test Juan Quintela
2018-01-10  6:37   ` Peter Xu
2018-01-10  8:46     ` Juan Quintela
2018-01-10  8:58       ` Peter Xu
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 06/11] tests: Add migration precopy test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 07/11] tests: Add basic migration precopy tcp test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 08/11] tests: Add migration xbzrle test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 09/11] tests: Create migrate-start-postcopy command Juan Quintela
2018-01-11 10:31   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 10/11] tests: Adjust sleeps for migration test Juan Quintela
2018-01-11 10:56   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 11/11] [RFH] tests: Add migration compress threads tests Juan Quintela
2018-01-10  6:42 ` [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Peter Xu
2018-01-10  9:12   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105215246.908-4-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).