qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v4 07/11] tests: Add basic migration precopy tcp test
Date: Fri,  5 Jan 2018 22:52:42 +0100	[thread overview]
Message-ID: <20180105215246.908-8-quintela@redhat.com> (raw)
In-Reply-To: <20180105215246.908-1-quintela@redhat.com>

Not sharing code from precopy/unix because we have to read back the
tcp parameter.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/migration-test.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 56 insertions(+), 3 deletions(-)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 88653ad767..024b6675fb 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -366,8 +366,7 @@ static void cleanup(const char *filename)
     g_free(path);
 }
 
-static void migrate_check_parameter(QTestState *who, const char *parameter,
-                                    const char *value)
+static char *migrate_get_parameter(QTestState *who, const char *parameter)
 {
     QDict *rsp, *rsp_return;
     char *result;
@@ -376,9 +375,18 @@ static void migrate_check_parameter(QTestState *who, const char *parameter,
     rsp_return = qdict_get_qdict(rsp, "return");
     result = g_strdup_printf("%" PRId64,
                              qdict_get_try_int(rsp_return,  parameter, -1));
+    QDECREF(rsp);
+    return result;
+}
+
+static void migrate_check_parameter(QTestState *who, const char *parameter,
+                                    const char *value)
+{
+    char *result;
+
+    result = migrate_get_parameter(who, parameter);
     g_assert_cmpstr(result, ==, value);
     g_free(result);
-    QDECREF(rsp);
 }
 
 static void migrate_set_parameter(QTestState *who, const char *parameter,
@@ -657,6 +665,50 @@ static void test_precopy_unix(void)
     g_free(uri);
 }
 
+static void test_precopy_tcp(void)
+{
+    char *uri;
+    char *port;
+    QTestState *from, *to;
+
+    test_migrate_start(&from, &to, "tcp:127.0.0.1:0");
+
+    /* We want to pick a speed slow enough that the test completes
+     * quickly, but that it doesn't complete precopy even on a slow
+     * machine, so also set the downtime.
+     */
+    /* 1 ms should make it not converge*/
+    migrate_set_parameter(from, "downtime-limit", "1");
+    /* 1GB/s */
+    migrate_set_parameter(from, "max-bandwidth", "1000000000");
+
+    /* Wait for the first serial output from the source */
+    wait_for_serial("src_serial");
+
+    port = migrate_get_parameter(to, "tcp-port");
+    uri = g_strdup_printf("tcp:127.0.0.1:%s", port);
+
+    migrate(from, uri);
+
+    wait_for_migration_pass(from);
+
+    /* 300 ms should converge */
+    migrate_set_parameter(from, "downtime-limit", "300");
+
+    if (!got_stop) {
+        qtest_qmp_eventwait(from, "STOP");
+    }
+
+    qtest_qmp_eventwait(to, "RESUME");
+
+    wait_for_serial("dest_serial");
+    wait_for_migration_complete(from);
+
+    test_migrate_end(from, to);
+    g_free(uri);
+    g_free(port);
+}
+
 int main(int argc, char **argv)
 {
     char template[] = "/tmp/migration-test-XXXXXX";
@@ -677,6 +729,7 @@ int main(int argc, char **argv)
     module_call_init(MODULE_INIT_QOM);
 
     qtest_add_func("/migration/precopy/unix", test_precopy_unix);
+    qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
     qtest_add_func("/migration/deprecated", test_deprecated);
     qtest_add_func("/migration/postcopy/unix", test_postcopy);
 
-- 
2.14.3

  parent reply	other threads:[~2018-01-05 21:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 21:52 [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 01/11] tests: Remove deprecated migration tests commands Juan Quintela
2018-01-11 12:48   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments Juan Quintela
2018-01-10  6:25   ` Peter Xu
2018-01-10  8:47     ` Juan Quintela
2018-01-10  9:21       ` Laurent Vivier
2018-01-10 10:12         ` Laurent Vivier
2018-01-10 10:43           ` Juan Quintela
2018-01-10 11:03             ` Laurent Vivier
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration Juan Quintela
2018-01-11 19:00   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration Juan Quintela
2018-01-10  6:30   ` Peter Xu
2018-01-10  8:43     ` Juan Quintela
2018-01-10  8:54       ` Peter Xu
2018-01-10 11:49         ` Dr. David Alan Gilbert
2018-01-10 14:58           ` Juan Quintela
2018-01-10 11:49   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test Juan Quintela
2018-01-10  6:37   ` Peter Xu
2018-01-10  8:46     ` Juan Quintela
2018-01-10  8:58       ` Peter Xu
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 06/11] tests: Add migration precopy test Juan Quintela
2018-01-05 21:52 ` Juan Quintela [this message]
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 08/11] tests: Add migration xbzrle test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 09/11] tests: Create migrate-start-postcopy command Juan Quintela
2018-01-11 10:31   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 10/11] tests: Adjust sleeps for migration test Juan Quintela
2018-01-11 10:56   ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 11/11] [RFH] tests: Add migration compress threads tests Juan Quintela
2018-01-10  6:42 ` [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Peter Xu
2018-01-10  9:12   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105215246.908-8-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).