qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com,
	qemu-block@nongnu.org, vsementsov@virtuozzo.com,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v7 08/20] null: Switch to .bdrv_co_block_status()
Date: Fri,  5 Jan 2018 16:57:41 -0600	[thread overview]
Message-ID: <20180105225753.30509-9-eblake@redhat.com> (raw)
In-Reply-To: <20180105225753.30509-1-eblake@redhat.com>

We are gradually moving away from sector-based interfaces, towards
byte-based.  Update the null driver accordingly.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Fam Zheng <famz@redhat.com>

---
v6-v7: no change
v5: minor fix to type of 'ret'
v4: rebase to interface tweak
v3: no change
v2: rebase to mapping parameter
---
 block/null.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/block/null.c b/block/null.c
index 0cdabaa440..2c16935f3c 100644
--- a/block/null.c
+++ b/block/null.c
@@ -222,22 +222,23 @@ static int null_reopen_prepare(BDRVReopenState *reopen_state,
     return 0;
 }

-static int64_t coroutine_fn null_co_get_block_status(BlockDriverState *bs,
-                                                     int64_t sector_num,
-                                                     int nb_sectors, int *pnum,
-                                                     BlockDriverState **file)
+static int coroutine_fn null_co_block_status(BlockDriverState *bs,
+                                             bool want_zero, int64_t offset,
+                                             int64_t bytes, int64_t *pnum,
+                                             int64_t *map,
+                                             BlockDriverState **file)
 {
     BDRVNullState *s = bs->opaque;
-    off_t start = sector_num * BDRV_SECTOR_SIZE;
+    int ret = BDRV_BLOCK_OFFSET_VALID;

-    *pnum = nb_sectors;
+    *pnum = bytes;
+    *map = offset;
     *file = bs;

     if (s->read_zeroes) {
-        return BDRV_BLOCK_OFFSET_VALID | start | BDRV_BLOCK_ZERO;
-    } else {
-        return BDRV_BLOCK_OFFSET_VALID | start;
+        ret |= BDRV_BLOCK_ZERO;
     }
+    return ret;
 }

 static void null_refresh_filename(BlockDriverState *bs, QDict *opts)
@@ -269,7 +270,7 @@ static BlockDriver bdrv_null_co = {
     .bdrv_co_flush_to_disk  = null_co_flush,
     .bdrv_reopen_prepare    = null_reopen_prepare,

-    .bdrv_co_get_block_status   = null_co_get_block_status,
+    .bdrv_co_block_status   = null_co_block_status,

     .bdrv_refresh_filename  = null_refresh_filename,
 };
@@ -289,7 +290,7 @@ static BlockDriver bdrv_null_aio = {
     .bdrv_aio_flush         = null_aio_flush,
     .bdrv_reopen_prepare    = null_reopen_prepare,

-    .bdrv_co_get_block_status   = null_co_get_block_status,
+    .bdrv_co_block_status   = null_co_block_status,

     .bdrv_refresh_filename  = null_refresh_filename,
 };
-- 
2.14.3

  parent reply	other threads:[~2018-01-05 22:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05 22:57 [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 01/20] block: Add .bdrv_co_block_status() callback Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 02/20] block: Switch passthrough drivers to .bdrv_co_block_status() Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 03/20] file-posix: Switch " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 04/20] gluster: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 05/20] iscsi: Switch cluster_sectors to byte-based Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() " Eric Blake
2018-01-08  8:08   ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status() Eric Blake
2018-01-08  8:14   ` Fam Zheng
2018-01-05 22:57 ` Eric Blake [this message]
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 09/20] parallels: " Eric Blake
2018-01-08  8:05   ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 10/20] qcow: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 11/20] qcow2: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 12/20] qed: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 13/20] raw: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 14/20] sheepdog: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 15/20] vdi: Avoid bitrot of debugging code Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 16/20] vdi: Switch to .bdrv_co_block_status() Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 17/20] vmdk: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 18/20] vpc: " Eric Blake
2018-01-08  8:14   ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 19/20] vvfat: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 20/20] block: Drop unused .bdrv_co_get_block_status() Eric Blake
2018-01-07  6:03 ` [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks no-reply
2018-01-08  2:56   ` Fam Zheng
2018-01-08  3:21     ` Fam Zheng
2018-01-29 20:11 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180105225753.30509-9-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).