From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, jcody@redhat.com, pl@kamp.de
Subject: Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks
Date: Mon, 8 Jan 2018 11:21:44 +0800 [thread overview]
Message-ID: <20180108032144.GB2123@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180108025648.GA2123@lemon.usersys.redhat.com>
On Mon, 01/08 10:56, Fam Zheng wrote:
> On Sat, 01/06 22:03, no-reply@patchew.org wrote:
> > /var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c: In function ‘iscsi_co_block_status’:
> > /var/tmp/patchew-tester-tmp-zu_flv2_/src/block/iscsi.c:755:14: error: ‘iTask.task’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > if (iTask.task != NULL) {
> > ~~~~~^~~~~
> > cc1: all warnings being treated as errors
> > make: *** [/var/tmp/patchew-tester-tmp-zu_flv2_/src/rules.mak:66: block/iscsi.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > === OUTPUT END ===
> >
> > Test command exited with code: 2
>
> Seems introduced by e38bc23454ef763deb4405ebdee6a1081aa00bc8. I think the easy
> fix is to initialize iTask.task to NULL.
I've posted a fix for this:
https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg01132.html
Fam
next prev parent reply other threads:[~2018-01-08 3:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 22:57 [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 01/20] block: Add .bdrv_co_block_status() callback Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 02/20] block: Switch passthrough drivers to .bdrv_co_block_status() Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 03/20] file-posix: Switch " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 04/20] gluster: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 05/20] iscsi: Switch cluster_sectors to byte-based Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 06/20] iscsi: Switch iscsi_allocmap_update() " Eric Blake
2018-01-08 8:08 ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 07/20] iscsi: Switch to .bdrv_co_block_status() Eric Blake
2018-01-08 8:14 ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 08/20] null: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 09/20] parallels: " Eric Blake
2018-01-08 8:05 ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 10/20] qcow: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 11/20] qcow2: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 12/20] qed: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 13/20] raw: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 14/20] sheepdog: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 15/20] vdi: Avoid bitrot of debugging code Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 16/20] vdi: Switch to .bdrv_co_block_status() Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 17/20] vmdk: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 18/20] vpc: " Eric Blake
2018-01-08 8:14 ` Fam Zheng
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 19/20] vvfat: " Eric Blake
2018-01-05 22:57 ` [Qemu-devel] [PATCH v7 20/20] block: Drop unused .bdrv_co_get_block_status() Eric Blake
2018-01-07 6:03 ` [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks no-reply
2018-01-08 2:56 ` Fam Zheng
2018-01-08 3:21 ` Fam Zheng [this message]
2018-01-29 20:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108032144.GB2123@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).