qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: surajjs@au1.ibm.com, groug@kaod.org, mdroth@linux.vnet.ibm.com,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 06/12] spapr_pci: use warn_report()
Date: Mon,  8 Jan 2018 16:53:42 +1100	[thread overview]
Message-ID: <20180108055348.20444-7-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180108055348.20444-1-david@gibson.dropbear.id.au>

From: Greg Kurz <groug@kaod.org>

These two are definitely warnings. Let's use the appropriate API.

Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/spapr_pci.c      | 6 +++---
 hw/ppc/spapr_pci_vfio.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 88797b3d36..695c820911 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1696,9 +1696,9 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp)
     /* DMA setup */
     if (((sphb->page_size_mask & qemu_getrampagesize()) == 0)
         && kvm_enabled()) {
-        error_report("System page size 0x%lx is not enabled in page_size_mask "
-                     "(0x%"PRIx64"). Performance may be slow",
-                     qemu_getrampagesize(), sphb->page_size_mask);
+        warn_report("System page size 0x%lx is not enabled in page_size_mask "
+                    "(0x%"PRIx64"). Performance may be slow",
+                    qemu_getrampagesize(), sphb->page_size_mask);
     }
 
     for (i = 0; i < windows_supported; ++i) {
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index 8448e0b024..1f775ea93d 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -50,7 +50,7 @@ static Property spapr_phb_vfio_properties[] = {
 static void spapr_phb_vfio_instance_init(Object *obj)
 {
     if (!qtest_enabled()) {
-        error_report("spapr-pci-vfio-host-bridge is deprecated");
+        warn_report("spapr-pci-vfio-host-bridge is deprecated");
     }
 }
 
-- 
2.14.3

  parent reply	other threads:[~2018-01-08  5:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08  5:53 [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108 David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 01/12] target-ppc: optimize cmp translation David Gibson
2018-01-18 16:36   ` Paolo Bonzini
2018-01-18 23:28     ` David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 02/12] pseries: Update SLOF firmware image to qemu-slof-20171214 David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 03/12] sm501: Add panel hardware cursor registers also to read function David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 04/12] sm501: Add some more unimplemented registers David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 05/12] ppc4xx_i2c: Implement basic I2C functions David Gibson
2018-01-08  5:53 ` David Gibson [this message]
2018-01-08  5:53 ` [Qemu-devel] [PULL 07/12] hw/ide: Emulate SiI3112 SATA controller David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 08/12] ppc/pnv: change powernv_ prefix to pnv_ for overall naming consistency David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 09/12] target/ppc: more use of the PPC_*() macros David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 10/12] Update dtc to fix compilation problem on Mac OS 10.6 David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 11/12] hw/ppc: Remove the deprecated spapr-pci-vfio-host-bridge device David Gibson
2018-01-08  5:53 ` [Qemu-devel] [PULL 12/12] spapr: Correct compatibility mode setting for hotplugged CPUs David Gibson
2018-01-09 11:46 ` [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108 Peter Maydell
2018-01-09 12:16   ` David Gibson
2018-01-09 15:15     ` Peter Maydell
2018-01-09 16:02       ` Michael Roth
2018-01-09 17:34         ` Paolo Bonzini
2018-01-09 17:57           ` Michael Roth
2018-01-10  0:41       ` Richard Henderson
2018-01-10  1:55       ` David Gibson
2018-01-10 13:33         ` Paolo Bonzini
2018-01-11  2:47           ` David Gibson
2018-01-11 14:18             ` Richard Henderson
2018-01-10 10:37     ` [Qemu-devel] [Qemu-ppc] " luigi burdo
2018-01-10 10:41       ` Peter Maydell
2018-01-10 16:02         ` luigi burdo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108055348.20444-7-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=surajjs@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).