From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL 08/14] 9pfs: make pdu_marshal() and pdu_unmarshal() static functions
Date: Mon, 8 Jan 2018 15:28:25 +0100 [thread overview]
Message-ID: <20180108142831.6638-9-groug@kaod.org> (raw)
In-Reply-To: <20180108142831.6638-1-groug@kaod.org>
They're only used by the 9p core code.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
hw/9pfs/9p.c | 4 ++--
hw/9pfs/9p.h | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 558efb41defd..1e4ebbe57687 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -41,7 +41,7 @@ enum {
Oappend = 0x80,
};
-ssize_t pdu_marshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
+static ssize_t pdu_marshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
{
ssize_t ret;
va_list ap;
@@ -53,7 +53,7 @@ ssize_t pdu_marshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
return ret;
}
-ssize_t pdu_unmarshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
+static ssize_t pdu_unmarshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
{
ssize_t ret;
va_list ap;
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index 6e3b48391788..ffe658ab8975 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -349,8 +349,6 @@ int v9fs_name_to_path(V9fsState *s, V9fsPath *dirpath,
int v9fs_device_realize_common(V9fsState *s, Error **errp);
void v9fs_device_unrealize_common(V9fsState *s, Error **errp);
-ssize_t pdu_marshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...);
-ssize_t pdu_unmarshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...);
V9fsPDU *pdu_alloc(V9fsState *s);
void pdu_free(V9fsPDU *pdu);
void pdu_submit(V9fsPDU *pdu, P9MsgHeader *hdr);
--
2.13.6
next prev parent reply other threads:[~2018-01-08 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 14:28 [Qemu-devel] [PULL 00/14] 9p patches for 2.12 20180108 Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 01/14] virtio-9p: move unrealize/realize after virtio_9p_transport definition Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 02/14] 9pfs: fix XattrOperations typedef Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 03/14] fsdev: fix some type definitions Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 04/14] 9pfs: " Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 05/14] 9pfs: handle: fix type definition Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 06/14] 9pfs: fix type in *_parse_opts declarations Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 07/14] 9pfs: fix error path in pdu_submit() Greg Kurz
2018-01-08 14:28 ` Greg Kurz [this message]
2018-01-08 14:28 ` [Qemu-devel] [PULL 09/14] tests: virtio-9p: fix ISR dependence Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 10/14] tests: virtio-9p: set DRIVER_OK before using the device Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 11/14] fsdev: improve error handling of backend opts parsing Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 12/14] fsdev: improve error handling of backend init Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 13/14] 9pfs: deprecate handle backend Greg Kurz
2018-01-08 14:28 ` [Qemu-devel] [PULL 14/14] MAINTAINERS: Drop Aneesh as 9pfs maintainer Greg Kurz
2018-01-09 9:47 ` [Qemu-devel] [PULL 00/14] 9p patches for 2.12 20180108 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108142831.6638-9-groug@kaod.org \
--to=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).