From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U
Date: Mon, 8 Jan 2018 15:41:36 +0100 [thread overview]
Message-ID: <20180108144136.GF8052@localhost.localdomain> (raw)
In-Reply-To: <20180105065538.13375-1-famz@redhat.com>
Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben:
> Management and users are accustomed to "qemu-img info" to query status of
> images even when they are used by guests. Since image locking was added, the -U
> (--force-share) option is needed for that to work. The reason has been that due
> to possible race with image header update, the output can be misleading.
>
> But what are likely to happen after we emit the error are that, for interactive
> users, '-U' will be used and the command retried; for management (nova, RHV,
> etc.), the operation is broken with no knob to workaround this.
>
> This series changes that error to a warning so that it doesn't get in the way.
Are management tools actually doing this? There is no good reason to
call 'qemu-img info' for an image that is in use by a VM.
If no, NACK. Automatically disabling locking because it can be
inconvenient defeats the purpose of locking.
If yes, clearly indicate that this usage is deprecated and we'll turn
this into an error again with 2.13. Then management tools can be fixed
in time.
Kevin
next prev parent reply other threads:[~2018-01-08 14:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 6:55 [Qemu-devel] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U Fam Zheng
2018-01-05 6:55 ` [Qemu-devel] [PATCH 1/2] qemu-img: Move img_open error reporting to callers Fam Zheng
2018-01-05 16:03 ` Eric Blake
2018-01-05 6:55 ` [Qemu-devel] [PATCH 2/2] qemu-img: info: try -U automatically Fam Zheng
2018-01-05 16:08 ` Eric Blake
2018-01-08 14:41 ` Kevin Wolf [this message]
2018-01-08 17:07 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U Nir Soffer
2018-01-08 17:57 ` Kevin Wolf
2018-01-09 6:24 ` Fam Zheng
2018-01-09 9:58 ` Kevin Wolf
2018-01-09 19:58 ` Ala Hino
2018-01-09 20:11 ` Eric Blake
2018-01-09 20:29 ` Ala Hino
2018-01-10 12:51 ` Daniel P. Berrange
2018-01-10 12:49 ` [Qemu-devel] " Daniel P. Berrange
2018-01-10 14:07 ` Kevin Wolf
2018-01-10 14:13 ` Daniel P. Berrange
2018-01-10 14:03 ` Kashyap Chamarthy
2018-01-10 16:43 ` [Qemu-devel] [Qemu-block] " Nir Soffer
2018-01-11 9:26 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108144136.GF8052@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).