From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Igor Mitsyanko <i.mitsyanko@gmail.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
"Sai Pavan Boddu" <saipava@xilinx.com>,
"Clement Deschamps" <clement.deschamps@antfield.fr>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Grégory Estrade" <gregory.estrade@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>,
qemu-arm@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PATCH v5 14/31] sdhci: add qtest to check the SD Spec version
Date: Mon, 8 Jan 2018 12:42:46 -0300 [thread overview]
Message-ID: <20180108154303.6522-15-f4bug@amsat.org> (raw)
In-Reply-To: <20180108154303.6522-1-f4bug@amsat.org>
with check_specs_version()
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/sdhci-test.c | 82 ++++++++++++++++++++++++++++++++++++++++++++++++++
tests/Makefile.include | 2 ++
2 files changed, 84 insertions(+)
create mode 100644 tests/sdhci-test.c
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
new file mode 100644
index 0000000000..492b332588
--- /dev/null
+++ b/tests/sdhci-test.c
@@ -0,0 +1,82 @@
+/*
+ * QTest testcase for SDHCI controllers
+ *
+ * Written by Philippe Mathieu-Daudé <f4bug@amsat.org>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+#include "qemu/osdep.h"
+#include "libqtest.h"
+
+#define SDHC_HCVER 0xFE
+
+static const struct sdhci_t {
+ const char *arch;
+ const char *machine;
+ struct {
+ uintptr_t addr;
+ uint8_t version;
+ uint8_t baseclock;
+ struct {
+ bool sdma;
+ uint64_t reg;
+ } capab;
+ } sdhci;
+} models[] = {
+ /* Exynos4210 */
+ { "arm", "smdkc210",
+ {0x12510000, 2, 0, {1, 0x5e80080} } },
+
+ /* Zynq-7000 */
+ { "arm", "xilinx-zynq-a9",
+ {0xe0100000, 2, 0, {1, 0x01790080} } },
+};
+
+static uint32_t sdhci_readl(uintptr_t base, uint32_t reg_addr)
+{
+ QTestState *qtest = global_qtest;
+
+ return qtest_readl(qtest, base + reg_addr);
+}
+
+static void check_specs_version(uintptr_t addr, uint8_t version)
+{
+ uint32_t v;
+
+ v = sdhci_readl(addr, SDHC_HCVER);
+ v &= 0xff;
+ v += 1;
+ g_assert_cmpuint(v, ==, version);
+}
+
+static void test_machine(const void *data)
+{
+ const struct sdhci_t *test = data;
+
+ global_qtest = qtest_startf("-machine %s -d unimp", test->machine);
+
+ check_specs_version(test->sdhci.addr, test->sdhci.version);
+
+ qtest_quit(global_qtest);
+}
+
+int main(int argc, char *argv[])
+{
+ const char *arch = qtest_get_arch();
+ char *name;
+ int i;
+
+ g_test_init(&argc, &argv, NULL);
+
+ for (i = 0; i < ARRAY_SIZE(models); i++) {
+ if (strcmp(arch, models[i].arch)) {
+ continue;
+ }
+ name = g_strdup_printf("sdhci/%s", models[i].machine);
+ qtest_add_data_func(name, &models[i], test_machine);
+ g_free(name);
+ }
+
+ return g_test_run();
+}
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 77f8183117..2d7058ca4c 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -357,6 +357,7 @@ check-qtest-arm-y += tests/virtio-blk-test$(EXESUF)
gcov-files-arm-y += arm-softmmu/hw/block/virtio-blk.c
check-qtest-arm-y += tests/test-arm-mptimer$(EXESUF)
gcov-files-arm-y += hw/timer/arm_mptimer.c
+check-qtest-arm-y += tests/sdhci-test$(EXESUF)
check-qtest-aarch64-y = tests/numa-test$(EXESUF)
@@ -612,6 +613,7 @@ tests/test-qht-par$(EXESUF): tests/test-qht-par.o tests/qht-bench$(EXESUF) $(tes
tests/qht-bench$(EXESUF): tests/qht-bench.o $(test-util-obj-y)
tests/test-bufferiszero$(EXESUF): tests/test-bufferiszero.o $(test-util-obj-y)
tests/atomic_add-bench$(EXESUF): tests/atomic_add-bench.o $(test-util-obj-y)
+tests/sdhci-test$(EXESUF): tests/sdhci-test.o
tests/test-qdev-global-props$(EXESUF): tests/test-qdev-global-props.o \
hw/core/qdev.o hw/core/qdev-properties.o hw/core/hotplug.o\
--
2.15.1
next prev parent reply other threads:[~2018-01-08 15:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 15:42 [Qemu-devel] [PATCH v5 00/31] SDHCI: make it abstract, add inherited devices, add qtests Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 01/31] sdhci: add a spec_version property Philippe Mathieu-Daudé
2018-01-08 21:41 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 02/31] sdhci: add basic Spec v1 capabilities Philippe Mathieu-Daudé
2018-01-08 22:00 ` Alistair Francis
2018-01-08 22:33 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 03/31] sdhci: add max-block-length capability (Spec v1) Philippe Mathieu-Daudé
2018-01-08 22:20 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 04/31] sdhci: add clock capabilities " Philippe Mathieu-Daudé
2018-01-08 22:22 ` Alistair Francis
2018-01-08 22:35 ` Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 05/31] sdhci: add DMA and 64-bit capabilities (Spec v2) Philippe Mathieu-Daudé
2018-01-09 21:53 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 07/31] sdhci: Fix 64-bit ADMA2 Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 08/31] hw/sd: clean/reorder the Makefile adding few comments Philippe Mathieu-Daudé
2018-01-08 21:53 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 09/31] sdhci: add a common class Philippe Mathieu-Daudé
2018-01-09 21:54 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 10/31] sdhci: add a Designware/Samsung host controller Philippe Mathieu-Daudé
2018-01-09 23:14 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 11/31] hw/arm/exynos4210: use the "samsung, exynos4210-dw-mshc" device Philippe Mathieu-Daudé
2018-01-09 23:18 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 12/31] sdhci: add the generic Arasan SDHCI 4.9a PHY controller Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 13/31] hw/arm/xilinx_zynq: use the "arasan, sdhci-4.9a" device Philippe Mathieu-Daudé
2018-01-08 15:42 ` Philippe Mathieu-Daudé [this message]
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 15/31] sdhci: check Spec v2 capabilities qtest Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 16/31] sdhci: add v3 capabilities Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 17/31] sdhci: rename the hostctl1 register Philippe Mathieu-Daudé
2018-01-08 21:54 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 18/31] sdhci: add the Broadcom BCM2835 SDHCI controller Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 19/31] hw/arm/bcm2835_peripherals: use the "brcm, bcm2835-sdhci" device Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 20/31] sdhci: add the Freescale controller for i.MX Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 21/31] hw/arm/fsl-imx6: use the "fsl, imx6q-usdhc" controller Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 22/31] sdhci: add the generic Arasan SDHCI 8.9a PHY Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 23/31] hw/arm/xilinx_zynqmp: use the "arasan, sdhci-8.9a" device Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 24/31] sdhci: let the SYSBUS_SDHCI type be abstract Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 25/31] sdhci: check Spec v3 capabilities qtest Philippe Mathieu-Daudé
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 26/31] sdhci: remove the deprecated 'capareg' property Philippe Mathieu-Daudé
2018-01-09 22:00 ` Alistair Francis
2018-01-08 15:42 ` [Qemu-devel] [PATCH v5 27/31] sdhci: add check_capab_readonly() qtest Philippe Mathieu-Daudé
2018-01-08 15:43 ` [Qemu-devel] [PATCH v5 28/31] sdhci: add a check_capab_baseclock() qtest Philippe Mathieu-Daudé
2018-01-08 15:43 ` [Qemu-devel] [PATCH v5 29/31] sdhci: add a check_capab_sdma() qtest Philippe Mathieu-Daudé
2018-01-08 15:43 ` [Qemu-devel] [PATCH v5 30/31] sdhci: add a check_capab_v3() qtest Philippe Mathieu-Daudé
2018-01-08 15:43 ` [Qemu-devel] [PATCH v5 31/31] sdhci: add Spec v4.2 register definitions Philippe Mathieu-Daudé
2018-01-18 18:21 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108154303.6522-15-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=alistair.francis@xilinx.com \
--cc=andrew.smirnov@gmail.com \
--cc=clement.deschamps@antfield.fr \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=gregory.estrade@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=jcd@tribudubois.net \
--cc=krzk@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saipava@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).