From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 02/12] slirp: struct icmp/ethhdr ARE packed
Date: Mon, 8 Jan 2018 14:28:54 -0300 [thread overview]
Message-ID: <20180108172904.8772-3-f4bug@amsat.org> (raw)
In-Reply-To: <20180108172904.8772-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
slirp/ip6_icmp.h | 6 +++---
slirp/ip_icmp.h | 2 +-
slirp/slirp.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/slirp/ip6_icmp.h b/slirp/ip6_icmp.h
index b3378b17b5..a4ccc69974 100644
--- a/slirp/ip6_icmp.h
+++ b/slirp/ip6_icmp.h
@@ -17,20 +17,20 @@
struct icmp6_echo { /* Echo Messages */
uint16_t id;
uint16_t seq_num;
-};
+} QEMU_PACKED;
union icmp6_error_body {
uint32_t unused;
uint32_t pointer;
uint32_t mtu;
-};
+} QEMU_PACKED;
/*
* NDP Messages
*/
struct ndp_rs { /* Router Solicitation Message */
uint32_t reserved;
-};
+} QEMU_PACKED;
struct ndp_ra { /* Router Advertisement Message */
uint8_t chl; /* Cur Hop Limit */
diff --git a/slirp/ip_icmp.h b/slirp/ip_icmp.h
index d88ab34c1b..e53242bdd8 100644
--- a/slirp/ip_icmp.h
+++ b/slirp/ip_icmp.h
@@ -88,7 +88,7 @@ struct icmp {
#define icmp_ip icmp_dun.id_ip.idi_ip
#define icmp_mask icmp_dun.id_mask
#define icmp_data icmp_dun.id_data
-};
+} QEMU_PACKED;
/*
* Lower bounds on packet lengths for various types.
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 9f29b52610..9a7287e7cc 100644
--- a/slirp/slirp.h
+++ b/slirp/slirp.h
@@ -103,7 +103,7 @@ struct ethhdr {
unsigned char h_dest[ETH_ALEN]; /* destination eth addr */
unsigned char h_source[ETH_ALEN]; /* source ether addr */
unsigned short h_proto; /* packet type ID field */
-};
+} QEMU_PACKED;
struct slirp_arphdr {
unsigned short ar_hrd; /* format of hardware address */
--
2.15.1
next prev parent reply other threads:[~2018-01-08 17:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:28 [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings Philippe Mathieu-Daudé
2018-01-08 17:28 ` [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it Philippe Mathieu-Daudé
2018-01-08 20:13 ` Thomas Huth
2018-01-09 20:54 ` Samuel Thibault
2018-01-08 17:28 ` Philippe Mathieu-Daudé [this message]
2018-01-08 17:43 ` [Qemu-devel] [PATCH 02/12] slirp: struct icmp/ethhdr ARE packed Thomas Huth
2018-01-08 17:28 ` [Qemu-devel] [PATCH 03/12] slirp: avoid IN6_IS_ADDR_UNSPECIFIED(), rather use in6_zero() Philippe Mathieu-Daudé
2018-01-09 21:04 ` Samuel Thibault
2018-01-08 17:28 ` [Qemu-devel] [PATCH 04/12] slirp: add in6_multicast() and use it instead of IN6_IS_ADDR_MULTICAST() Philippe Mathieu-Daudé
2018-01-08 20:10 ` Thomas Huth
2018-01-09 16:33 ` Richard Henderson
2018-01-09 17:08 ` Thomas Huth
2018-01-09 21:18 ` Samuel Thibault
2018-01-08 17:28 ` [Qemu-devel] [PATCH 05/12] slirp: poison IN6_*_ADDR_*() macros to avoid them Philippe Mathieu-Daudé
2018-01-08 17:46 ` Thomas Huth
2018-01-08 17:28 ` [Qemu-devel] [PATCH 06/12] slirp: remove unused header Philippe Mathieu-Daudé
2018-01-08 18:54 ` Thomas Huth
2018-01-09 21:21 ` Samuel Thibault
2018-01-08 17:28 ` [Qemu-devel] [PATCH 07/12] slirp: remove unnecessary Philippe Mathieu-Daudé
2018-01-08 19:01 ` Thomas Huth
2018-01-09 21:23 ` Samuel Thibault
2018-01-08 17:29 ` [Qemu-devel] [PATCH 08/12] slirp: removed unused code Philippe Mathieu-Daudé
2018-01-08 19:02 ` Thomas Huth
2018-01-09 21:24 ` Samuel Thibault
2018-01-08 17:29 ` [Qemu-devel] [PATCH 09/12] slirp: add in6_dhcp_multicast() Philippe Mathieu-Daudé
2018-01-09 21:26 ` Samuel Thibault
2018-01-08 17:29 ` [Qemu-devel] [PATCH 10/12] configure: disable unaligned access warning on x86 arch Philippe Mathieu-Daudé
2018-01-08 17:32 ` Peter Maydell
2018-01-08 17:53 ` Michael S. Tsirkin
2018-01-08 18:24 ` Philippe Mathieu-Daudé
2018-01-08 17:29 ` [Qemu-devel] [PATCH 11/12] configure: add HOST_SUPPORTS_UNALIGNED_ACCESS Philippe Mathieu-Daudé
2018-01-08 17:29 ` [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS Philippe Mathieu-Daudé
2018-01-09 9:52 ` Paolo Bonzini
2018-01-09 21:30 ` Samuel Thibault
2018-01-08 19:41 ` [Qemu-devel] [PATCH 00/12] add HOST_SUPPORTS_UNALIGNED_ACCESS, reduce slirp warnings no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108172904.8772-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).