qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Jiri Pirko <jiri@resnulli.us>, Jason Wang <jasowang@redhat.com>,
	Dmitry Fleytman <dmitry@daynix.com>, Stefan Weil <sw@weilnetz.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>
Subject: [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit)
Date: Mon,  8 Jan 2018 15:02:30 -0300	[thread overview]
Message-ID: <20180108180231.21122-7-f4bug@amsat.org> (raw)
In-Reply-To: <20180108180231.21122-1-f4bug@amsat.org>

as suggested in the comment.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/net/eepro100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c
index 61d767524f..abb44710d9 100644
--- a/hw/net/eepro100.c
+++ b/hw/net/eepro100.c
@@ -266,7 +266,7 @@ typedef struct {
 
     /* Data in mem is always in the byte order of the controller (le).
      * It must be dword aligned to allow direct access to 32 bit values. */
-    uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED(8);
+    uint8_t mem[PCI_MEM_SIZE] QEMU_ALIGNED(4);
 
     /* Configuration bytes. */
     uint8_t configuration[22];
-- 
2.15.1

  parent reply	other threads:[~2018-01-08 18:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 18:02 [Qemu-devel] [PATCH 0/7] use QEMU_PACKED and QEMU_ALIGNED macros Philippe Mathieu-Daudé
2018-01-08 18:02 ` [Qemu-devel] [PATCH 1/7] net: struct MACAddr can use the QEMU_PACKED macro Philippe Mathieu-Daudé
2018-01-09 16:26   ` Richard Henderson
2018-01-08 18:02 ` [Qemu-devel] [PATCH 2/7] net/eth: " Philippe Mathieu-Daudé
2018-01-08 18:02 ` [Qemu-devel] [PATCH 3/7] net/rocker: use QEMU_PACKED and QEMU_ALIGNED() macros Philippe Mathieu-Daudé
2018-01-09 16:27   ` Richard Henderson
2018-01-08 18:02 ` [Qemu-devel] [PATCH 4/7] net/rocker: move struct rocker_desc to C file Philippe Mathieu-Daudé
2018-01-09 16:27   ` Richard Henderson
2018-01-08 18:02 ` [Qemu-devel] [PATCH 5/7] net/eepro100: use QEMU_ALIGNED() macro Philippe Mathieu-Daudé
2018-01-09 16:27   ` Richard Henderson
2018-01-08 18:02 ` Philippe Mathieu-Daudé [this message]
2018-01-08 18:10   ` [Qemu-devel] [RFC PATCH 6/7] net/eepro100: reduce alignment to DWORD (32bit) Paolo Bonzini
2018-01-08 18:28     ` Philippe Mathieu-Daudé
2018-01-08 18:02 ` [Qemu-devel] [PATCH 7/7] i386/pc: use the QEMU_ALIGNED() macro Philippe Mathieu-Daudé
2018-01-08 18:53   ` Marcel Apfelbaum
2018-01-09 16:28   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180108180231.21122-7-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=dmitry@daynix.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).