From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYbsU-0002ww-3R for qemu-devel@nongnu.org; Mon, 08 Jan 2018 13:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYbsQ-000569-0d for qemu-devel@nongnu.org; Mon, 08 Jan 2018 13:10:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52862) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYbsP-00055E-N6 for qemu-devel@nongnu.org; Mon, 08 Jan 2018 13:10:25 -0500 Date: Mon, 8 Jan 2018 20:10:23 +0200 From: "Michael S. Tsirkin" Message-ID: <20180108200725-mutt-send-email-mst@kernel.org> References: <1513866427-27125-1-git-send-email-mst@redhat.com> <20171221223704-mutt-send-email-mst@kernel.org> <20171222014258-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: features, fixes, cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , QEMU Developers , David Gibson , Thomas Huth On Mon, Jan 08, 2018 at 09:14:41AM +0000, Peter Maydell wrote: > On 21 December 2017 at 23:43, Michael S. Tsirkin wrote: > >> you also need to drop "hw/pci: remove obsolete PCIDevice->init()" > >> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420) > >> else the not-yet-QOM'ified NVME won't work anymore. > > > > Done that too, thanks a lot > > Hi. I'm afraid this pullreq (merge of 880b1ff) has new runtime > errors from the clang sanitizer: > > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: > runtime error: load of misaligned address 0x55b4ffee8246 for type > 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:208:65: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: > runtime error: load of misaligned address 0x55b4ffee8246 for type > 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > > Sorry for the late report, I didn't quite have time > to process the pull before Christmas holidays. > > thanks > -- PMM So I bisected and the reason is this commit: commit 18b20bb43a2f37f0c8ae23a3e9b3d9a4a05b6bd4 Author: David Gibson Date: Tue Dec 19 15:45:22 2017 +1100 tests/pxe-test: Add some extra tests Previously virtio-net was only tested for ppc64 in "slow" mode. That doesn't make much sense since virtio-net is used much more often in practice than the spapr-vlan device which was tested always. So, move virtio-net to always be tested on ppc64. We had no tests at all for the q35 machine, which doesn't seem wise given its increasing prominence. Add a couple of tests for it, including testing the newer e1000e adapter. Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin :040000 040000 5a982bfea24b9ac3c651b84425a39b3c85f4871e 771af3fdfb2778c6d6ed6b1098d1e79c181d6fb0 M tests Pls either fix or drop e1000e test -- MST