From: "Michael S. Tsirkin" <mst@redhat.com>
To: linzhecheng <linzhecheng@huawei.com>
Cc: qemu-devel@nongnu.org, arei.gonglei@huawei.com,
peterx@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] irq: fix memory leak
Date: Tue, 9 Jan 2018 06:13:40 +0200 [thread overview]
Message-ID: <20180109061322-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171225024704.19540-1-linzhecheng@huawei.com>
On Mon, Dec 25, 2017 at 10:47:04AM +0800, linzhecheng wrote:
> entry is moved from list but is not freed.
>
> Signed-off-by: linzhecheng <linzhecheng@huawei.com>
Makes sense.
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 351b64f77c..3c920db79a 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -3494,6 +3494,7 @@ int kvm_arch_release_virq_post(int virq)
> if (entry->virq == virq) {
> trace_kvm_x86_remove_msi_route(virq);
> QLIST_REMOVE(entry, list);
> + g_free(entry);
> break;
> }
> }
> --
> 2.12.2.windows.2
>
next prev parent reply other threads:[~2018-01-09 4:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 2:47 [Qemu-devel] [PATCH] irq: fix memory leak linzhecheng
2017-12-25 5:33 ` Peter Xu
2017-12-25 6:59 ` Peter Xu
2018-01-09 4:13 ` Michael S. Tsirkin [this message]
2018-01-09 17:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109061322-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=linzhecheng@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).