From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYwou-00026M-Do for qemu-devel@nongnu.org; Tue, 09 Jan 2018 11:32:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYwop-0005Ce-Gx for qemu-devel@nongnu.org; Tue, 09 Jan 2018 11:32:12 -0500 Date: Tue, 9 Jan 2018 17:31:37 +0100 From: Cornelia Huck Message-ID: <20180109173137.5b8bd15f.cohuck@redhat.com> In-Reply-To: <20171211134740.8235-6-david@redhat.com> References: <20171211134740.8235-1-david@redhat.com> <20171211134740.8235-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 for-2-12 05/15] s390x/tcg: simplify machine check handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Christian Borntraeger , Richard Henderson , Alexander Graf , Paolo Bonzini , Peter Crosthwaite , Thomas Huth On Mon, 11 Dec 2017 14:47:30 +0100 David Hildenbrand wrote: > We currently only support CRW machine checks. This is a preparation for > real floating interrupt support. > > Get rid of the queue and handle it via the bit INTERRUPT_MCHK. We don't > rename it for now, as it will be soon gone (when moving crw machine checks > into the flic). > > Please note that this is the same way also KVM handles it: only one > instance of a machine check can be pending at a time. So no need for a > queue. That's basically architecture (IIRC, it's been a while). More pending machine checks are handled by merging into the mcic. > > While at it, make sure we try to deliver only if env->cregs[14] > actually indicates that CRWs are accepted. > > Drop two unused defines on the way (we already have PSW_MASK_...). > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.c | 2 -- > target/s390x/cpu.h | 10 ---------- > target/s390x/excp_helper.c | 29 +++++------------------------ > target/s390x/interrupt.c | 18 +++++++----------- > 4 files changed, 12 insertions(+), 47 deletions(-)