From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration
Date: Wed, 10 Jan 2018 17:12:18 +0800 [thread overview]
Message-ID: <20180110091218.GL5984@xz-mi> (raw)
In-Reply-To: <20180110064252.GE5984@xz-mi>
On Wed, Jan 10, 2018 at 02:42:52PM +0800, Peter Xu wrote:
> On Fri, Jan 05, 2018 at 10:52:35PM +0100, Juan Quintela wrote:
> >
> > Hi
> >
> > In v4:
> >
> > Based-on: 20180105205109.683-1-quintela@redhat.com
> >
> > Changes:
> > - rebase on top on v4 info_migrate patches
> > - Tune sleeps to make patches fast
> > - Create a deprecated test for deprecated commands (i.e. make peterxu happy)
> > - create migrate_start_postcopy function
> > - fix naming/sizes between power and x86
> > - cleanup comments to match code
> >
> > Please, review.
>
> I left some comments on specific patches, for the rest I think the
> series looks good to me. Thanks,
I believe Dave would be a better person to ack, but as a potential
user of the series (who wants to use it soon), I'd like to provide my
r-b before Dave provides (possibly) more comments, so:
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
prev parent reply other threads:[~2018-01-10 9:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 21:52 [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 01/11] tests: Remove deprecated migration tests commands Juan Quintela
2018-01-11 12:48 ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments Juan Quintela
2018-01-10 6:25 ` Peter Xu
2018-01-10 8:47 ` Juan Quintela
2018-01-10 9:21 ` Laurent Vivier
2018-01-10 10:12 ` Laurent Vivier
2018-01-10 10:43 ` Juan Quintela
2018-01-10 11:03 ` Laurent Vivier
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 03/11] tests: Consolidate accelerators declaration Juan Quintela
2018-01-11 19:00 ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration Juan Quintela
2018-01-10 6:30 ` Peter Xu
2018-01-10 8:43 ` Juan Quintela
2018-01-10 8:54 ` Peter Xu
2018-01-10 11:49 ` Dr. David Alan Gilbert
2018-01-10 14:58 ` Juan Quintela
2018-01-10 11:49 ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test Juan Quintela
2018-01-10 6:37 ` Peter Xu
2018-01-10 8:46 ` Juan Quintela
2018-01-10 8:58 ` Peter Xu
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 06/11] tests: Add migration precopy test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 07/11] tests: Add basic migration precopy tcp test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 08/11] tests: Add migration xbzrle test Juan Quintela
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 09/11] tests: Create migrate-start-postcopy command Juan Quintela
2018-01-11 10:31 ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 10/11] tests: Adjust sleeps for migration test Juan Quintela
2018-01-11 10:56 ` Dr. David Alan Gilbert
2018-01-05 21:52 ` [Qemu-devel] [PATCH v4 11/11] [RFH] tests: Add migration compress threads tests Juan Quintela
2018-01-10 6:42 ` [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration Peter Xu
2018-01-10 9:12 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110091218.GL5984@xz-mi \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).