From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZEtO-0003dj-H7 for qemu-devel@nongnu.org; Wed, 10 Jan 2018 06:50:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZEtM-0000kV-N6 for qemu-devel@nongnu.org; Wed, 10 Jan 2018 06:50:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51536) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZEtM-0000jm-GD for qemu-devel@nongnu.org; Wed, 10 Jan 2018 06:50:00 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 91D8481DEA for ; Wed, 10 Jan 2018 11:49:59 +0000 (UTC) Date: Wed, 10 Jan 2018 11:49:53 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180110114953.GB2450@work-vm> References: <20180105215246.908-1-quintela@redhat.com> <20180105215246.908-5-quintela@redhat.com> <20180110063022.GC5984@xz-mi> <87r2qyyugr.fsf@secure.laptop> <20180110085452.GJ5984@xz-mi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110085452.GJ5984@xz-mi> Subject: Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Juan Quintela , qemu-devel@nongnu.org, lvivier@redhat.com * Peter Xu (peterx@redhat.com) wrote: > On Wed, Jan 10, 2018 at 09:43:48AM +0100, Juan Quintela wrote: > > Peter Xu wrote: > > > On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: > > >> Signed-off-by: Juan Quintela > > >> --- > > >> tests/migration-test.c | 12 ++++++------ > > >> 1 file changed, 6 insertions(+), 6 deletions(-) > > >> > > >> diff --git a/tests/migration-test.c b/tests/migration-test.c > > >> index d81f22118b..f469235d0b 100644 > > >> --- a/tests/migration-test.c > > >> +++ b/tests/migration-test.c > > >> @@ -440,13 +440,13 @@ static void test_migrate_start(QTestState **from, QTestState **to, > > >> > > >> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) { > > >> init_bootfile_x86(bootpath); > > >> - cmd_src = g_strdup_printf("-machine accel=%s -m 150M" > > >> - " -name pcsource,debug-threads=on" > > >> + cmd_src = g_strdup_printf("-machine accel=%s -m 256M" > > >> + " -name source,debug-threads=on" > > > > > > A pure question: when will the name matter? > > > > It don't matter, but ARM didn't want to use the pcname, and decided for > > yet a different command line. I would like to have the same command > > line for all architectures. At least the less gratuitous differences. > > > > As you can guess, name don't matter at all., but telling ARNM people to > > be consistent with things that are not consistent .... O:-) > > Ah, fine. :) > > This test only support x86 and ppc for now, right? > > (Btw, AFAIK debug-threads=on is only useful if any of us wants to > glance at thread names. In other words, would it be even simpler to > just remove that "-name" line? :-) It makes debugging hangs/crashes easier sometimes, so keep it. Dave > -- > Peter Xu -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK