From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment
Date: Wed, 10 Jan 2018 15:04:14 +0000 [thread overview]
Message-ID: <20180110150413.GE2450@work-vm> (raw)
In-Reply-To: <20180110143742.GD2450@work-vm>
* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
> > These are basically David's patches, with a couple changes for clarity
> > and robustness.
>
> Yes, those look fine to me.
> (Patchew seems to be annoyed at the Tracing - I can't see why)
Stefan has explained this to me; we need to remove the spaces after the
PRIx64 macro calls in the first patch.
Dave
> Dave
>
> > Dr. David Alan Gilbert (2):
> > find_ram_offset: Add comments and tracing
> > find_ram_offset: Align ram_addr_t allocation on long boundaries
> >
> > exec.c | 33 ++++++++++++++++++++++++++-------
> > trace-events | 4 ++++
> > 2 files changed, 30 insertions(+), 7 deletions(-)
> >
> > --
> > 2.14.3
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2018-01-10 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 14:25 [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment Paolo Bonzini
2018-01-10 14:25 ` [Qemu-devel] [PATCH 1/2] find_ram_offset: Add comments and tracing Paolo Bonzini
2018-01-10 14:25 ` [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries Paolo Bonzini
2018-01-10 14:31 ` [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment no-reply
2018-01-10 14:32 ` no-reply
2018-01-10 14:37 ` Dr. David Alan Gilbert
2018-01-10 15:04 ` Dr. David Alan Gilbert [this message]
2018-01-10 15:08 ` Eric Blake
2018-01-10 14:44 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110150413.GE2450@work-vm \
--to=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).