From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZHvU-0008Gz-Aq for qemu-devel@nongnu.org; Wed, 10 Jan 2018 10:04:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZHvQ-0006RD-Bv for qemu-devel@nongnu.org; Wed, 10 Jan 2018 10:04:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59650) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZHvQ-0006QW-5u for qemu-devel@nongnu.org; Wed, 10 Jan 2018 10:04:20 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D1157C83B for ; Wed, 10 Jan 2018 15:04:19 +0000 (UTC) Date: Wed, 10 Jan 2018 15:04:14 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20180110150413.GE2450@work-vm> References: <20180110142515.13242-1-pbonzini@redhat.com> <20180110143742.GD2450@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110143742.GD2450@work-vm> Subject: Re: [Qemu-devel] [PATCH v2 0/2] find_ram_offset cleanups and alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, quintela@redhat.com, eblake@redhat.com * Dr. David Alan Gilbert (dgilbert@redhat.com) wrote: > * Paolo Bonzini (pbonzini@redhat.com) wrote: > > These are basically David's patches, with a couple changes for clarity > > and robustness. > > Yes, those look fine to me. > (Patchew seems to be annoyed at the Tracing - I can't see why) Stefan has explained this to me; we need to remove the spaces after the PRIx64 macro calls in the first patch. Dave > Dave > > > Dr. David Alan Gilbert (2): > > find_ram_offset: Add comments and tracing > > find_ram_offset: Align ram_addr_t allocation on long boundaries > > > > exec.c | 33 ++++++++++++++++++++++++++------- > > trace-events | 4 ++++ > > 2 files changed, 30 insertions(+), 7 deletions(-) > > > > -- > > 2.14.3 > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK