From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZJT9-0002Cq-RM for qemu-devel@nongnu.org; Wed, 10 Jan 2018 11:43:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZJT6-0004BU-LX for qemu-devel@nongnu.org; Wed, 10 Jan 2018 11:43:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34780) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZJT6-0004An-CE for qemu-devel@nongnu.org; Wed, 10 Jan 2018 11:43:12 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E52E356E0 for ; Wed, 10 Jan 2018 16:43:11 +0000 (UTC) Date: Wed, 10 Jan 2018 16:43:03 +0000 From: "Daniel P. Berrange" Message-ID: <20180110164303.GQ3205@redhat.com> Reply-To: "Daniel P. Berrange" References: <20171212113440.16483-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171212113440.16483-1-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ui: deprecate use of GTK 2.x in favour of 3.x series List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann ping. Gerd, do you have any opinions on this, and also deprecating SDL-1 ? On Tue, Dec 12, 2017 at 11:34:40AM +0000, Daniel P. Berrange wrote: > The GTK 3.0 release was made in Feb, 2011: > > https://blog.gtk.org/2011/02/10/gtk-3-0-released/ > > That will soon be 7 years ago, which is enough time to consider > the 3.x series widely supported. > > Thus we deprecate the GTK 2.x support, which will allow us to > delete it in the last release of 2018. By this time, GTK 3.x > will be almost 8 years old. > > Signed-off-by: Daniel P. Berrange > --- > configure | 6 ++++++ > qemu-doc.texi | 9 +++++++++ > ui/gtk.c | 5 +++++ > 3 files changed, 20 insertions(+) > > diff --git a/configure b/configure > index 0c6e7572db..1c5110dc5e 100755 > --- a/configure > +++ b/configure > @@ -5560,6 +5560,12 @@ if test "$sdl_too_old" = "yes"; then > echo "-> Your SDL version is too old - please upgrade to have SDL support" > fi > > +if test "$gtkabi" = "2.0"; then > + echo > + echo "WARNING: Use of GTK 2.0 is deprecated and will be removed in" > + echo "WARNING: future releases. Please switch to using GTK 3.0" > +fi > + > if test "$supported_cpu" = "no"; then > echo > echo "WARNING: SUPPORT FOR THIS HOST CPU WILL GO AWAY IN FUTURE RELEASES!" > diff --git a/qemu-doc.texi b/qemu-doc.texi > index db2351c746..ab03031da3 100644 > --- a/qemu-doc.texi > +++ b/qemu-doc.texi > @@ -2371,6 +2371,15 @@ they were first deprecated in the 2.10.0 release. > What follows is a list of all features currently marked as > deprecated. > > +@section Build options > + > +@subsection GTK 2.x > + > +Previously QEMU has supported building against both GTK 2.x > +and 3.x series APIs. Support for the GTK 2.x builds will be > +discontinued, so maintainers should switch to using GTK 3.x, > +which is the default. > + > @section System emulator command line arguments > > @subsection -drive boot=on|off (since 1.3.0) > diff --git a/ui/gtk.c b/ui/gtk.c > index 342e96fbe9..f3b7567984 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -2248,6 +2248,11 @@ void gtk_display_init(DisplayState *ds, bool full_screen, bool grab_on_hover) > exit(1); > } > > +#if !GTK_CHECK_VERSION(3, 0, 0) > + g_printerr("Running QEMU with GTK 2.x is deprecated, and will be removed\n" > + "in a future release. Please switch to GTK 3.x instead\n"); > +#endif > + > s->window = gtk_window_new(GTK_WINDOW_TOPLEVEL); > #if GTK_CHECK_VERSION(3, 2, 0) > s->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0); > -- > 2.14.3 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|