From: Tao Wu <lepton@google.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
Tao Wu <lepton@google.com>
Subject: [Qemu-devel] [PATCH v2 3/3] target/i386: hax: Move x86_update_hflags.
Date: Wed, 10 Jan 2018 11:50:56 -0800 [thread overview]
Message-ID: <20180110195056.85403-3-lepton@google.com> (raw)
In-Reply-To: <20180110195056.85403-1-lepton@google.com>
x86_update_hflags reference env->efer which is updated in hax_get_msrs,
so it has to be called after hax_get_msrs. This fix the bug that sometimes
dump_state show 32 bits regs even in 64 bits mode.
Signed-off-by: Tao Wu <lepton@google.com>
---
target/i386/hax-all.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
index dc379373f7..5a4a5025b9 100644
--- a/target/i386/hax-all.c
+++ b/target/i386/hax-all.c
@@ -838,9 +838,6 @@ static int hax_sync_vcpu_register(CPUArchState *env, int set)
return -1;
}
}
- if (!set) {
- x86_update_hflags(env);
- }
return 0;
}
@@ -1021,6 +1018,7 @@ static int hax_arch_get_registers(CPUArchState *env)
return ret;
}
+ x86_update_hflags(env);
return 0;
}
--
2.16.0.rc1.238.g530d649a79-goog
next prev parent reply other threads:[~2018-01-10 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 6:47 [Qemu-devel] [PATCH] target/i386: hax: Move hax_setup_qemu_emulator Tao Wu
2018-01-10 13:27 ` Paolo Bonzini
2018-01-10 18:05 ` Tao Wu(吴涛@Eng)
2018-01-10 19:50 ` [Qemu-devel] [PATCH v2 1/3] target/i386: move hflags update code to a function Tao Wu
2018-01-10 19:50 ` [Qemu-devel] [PATCH v2 2/3] target/i386: hax: change to use x86_update_hflags Tao Wu
2018-01-10 19:50 ` Tao Wu [this message]
2018-01-11 13:16 ` [Qemu-devel] [PATCH v2 1/3] target/i386: move hflags update code to a function Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110195056.85403-3-lepton@google.com \
--to=lepton@google.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).