From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZixD-00088e-Gk for qemu-devel@nongnu.org; Thu, 11 Jan 2018 14:56:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZix9-0004Gx-KP for qemu-devel@nongnu.org; Thu, 11 Jan 2018 14:55:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47338) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZix9-0004GB-DR for qemu-devel@nongnu.org; Thu, 11 Jan 2018 14:55:55 -0500 Date: Thu, 11 Jan 2018 21:55:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20180111215411-mutt-send-email-mst@kernel.org> References: <1515515942-33692-1-git-send-email-jianjay.zhou@huawei.com> <20180111140057.61f36a8f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zhoujian (jay)" Cc: Igor Mammedov , "qemu-devel@nongnu.org" , "Huangweidong (C)" , "wangxin (U)" , "Gonglei (Arei)" , "Liuzhe (Ahriy, Euler)" On Thu, Jan 11, 2018 at 01:55:38PM +0000, Zhoujian (jay) wrote: > Hi Igor, > > > -----Original Message----- > > From: Igor Mammedov [mailto:imammedo@redhat.com] > > Sent: Thursday, January 11, 2018 9:05 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org; mst@redhat.com; Huangweidong (C) > > ; wangxin (U) ; Gonglei > > (Arei) ; Liuzhe (Ahriy, Euler) > > Subject: Re: [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring > > > > On Wed, 10 Jan 2018 00:39:02 +0800 > > Jay Zhou wrote: > > > > Jay, > > considering how non trivial touched code is, would you mind first adding > > 'make check' testcases for success/failure paths that you are touching? > > It would help with merging and ensure that future changes to vhost won't > > break memslots handling. > > Will look into the testcases. Maybe it would take some time since I'm not > very familiar with them. > > Regards, > Jay ok can you repost whatever's ready please? And please use proper threading (e.g. generated with git format-patch --thread=shallow). > > > > > v4 -> v5: > > > Making the followed up device_add to fall back to userspace > > > virtio when netdev_add fails if vhost force flag does not set. > > > > > > Jay Zhou (4): > > > vhost: remove assertion to prevent crash > > > tap: do not close fd if only vhost failed to initialize > > > vhost: fix memslot limit check > > > vhost: used_memslots refactoring > > > > > > hw/virtio/vhost-backend.c | 15 +++++++- > > > hw/virtio/vhost-user.c | 74 +++++++++++++++++++++++++++-------- > > ---- > > > hw/virtio/vhost.c | 30 +++++++++------- > > > include/hw/virtio/vhost-backend.h | 6 ++-- > > > net/tap.c | 25 +++++++++---- > > > 5 files changed, 104 insertions(+), 46 deletions(-) > > > > > > -- > > > 1.8.3.1 > > > > > >