From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Keith Busch <keith.busch@intel.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Karl Rister <krister@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver
Date: Fri, 12 Jan 2018 11:09:54 +0800 [thread overview]
Message-ID: <20180112030954.GC29151@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180110183304.GE24212@stefanha-x1.localdomain>
On Wed, 01/10 18:33, Stefan Hajnoczi wrote:
> > + ret = event_notifier_init(&s->irq_notifier, 0);
> > + if (ret) {
> > + error_setg(errp, "Failed to init event notifier");
> > + return ret;
>
> dma_map_lock should be destroyed.
CoMutexes are initialized by memset so I don't think destroying is necessary:
void qemu_co_mutex_init(CoMutex *mutex)
{
memset(mutex, 0, sizeof(*mutex));
}
(I agree to and will fix other issues you pointed out. Thanks for the quick
review!)
Fam
next prev parent reply other threads:[~2018-01-12 3:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:18 [Qemu-devel] [PATCH v4 0/9] block: Add VFIO based driver for NVMe device Fam Zheng
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 1/9] stubs: Add stubs for ram block API Fam Zheng
2018-01-10 16:52 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 2/9] util: Introduce vfio helpers Fam Zheng
2018-01-10 16:52 ` Stefan Hajnoczi
2018-01-12 1:28 ` Fam Zheng
2018-01-10 20:09 ` Alex Williamson
2018-01-12 1:51 ` Fam Zheng
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver Fam Zheng
2018-01-10 14:43 ` Eric Blake
2018-01-10 14:48 ` Paolo Bonzini
2018-01-10 14:44 ` Eric Blake
2018-01-12 3:11 ` Fam Zheng
2018-01-10 18:33 ` Stefan Hajnoczi
2018-01-11 13:48 ` Paolo Bonzini
2018-01-12 3:09 ` Fam Zheng [this message]
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 4/9] block: Introduce buf register API Fam Zheng
2018-01-10 18:55 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 5/9] block/nvme: Implement .bdrv_(un)register_buf Fam Zheng
2018-01-10 18:56 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 6/9] qemu-img: Map bench buffer Fam Zheng
2018-01-10 18:56 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 7/9] block: Move NVMe constants to a separate header Fam Zheng
2018-01-10 18:57 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 8/9] docs: Add section for NVMe VFIO driver Fam Zheng
2018-01-10 19:05 ` Stefan Hajnoczi
2018-01-10 9:18 ` [Qemu-devel] [PATCH v4 9/9] qapi: Add NVMe driver options to the schema Fam Zheng
2018-01-10 14:41 ` Eric Blake
2018-01-12 3:12 ` Fam Zheng
2018-01-10 19:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112030954.GC29151@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=keith.busch@intel.com \
--cc=krister@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).