From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Keith Busch <keith.busch@intel.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
alex.williamson@redhat.com, Markus Armbruster <armbru@redhat.com>,
Karl Rister <krister@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/9] block: Add VFIO based driver for NVMe device
Date: Fri, 12 Jan 2018 09:46:19 +0000 [thread overview]
Message-ID: <20180112094619.GC7356@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180112085555.14447-1-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Fri, Jan 12, 2018 at 04:55:46PM +0800, Fam Zheng wrote:
> v5: Add Stefan's rev-bys.
> Add Paolo's sob line.
> Address Stefan's, Alex's and Eric's comments, including:
> - Add PCI Bar MMIO offset/size parameter to VFIO utility API. [Alex]
> - Fix various lock and memory leakings. [Stefan]
> - Improve documentation. [Stefan]
> - Add one missing "Since 2.12" in QAPI schema. [Eric]
> - Fix locking of BDRVNVMeState->inflight. [Stefan]
> - Add one missing endianness conversion for cmd.nsid. [Stefan]
> - Use bdrv_get_aio_context() instead of qemu_get_current_aio_context().
> - When init, issue "Set Features" command to enable/disable volatile write
> cache according to "flags & BDRV_O_NOCACHE".
I left comments on the main patch. The rest looks good.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-01-12 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 8:55 [Qemu-devel] [PATCH v5 0/9] block: Add VFIO based driver for NVMe device Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 1/9] stubs: Add stubs for ram block API Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 2/9] util: Introduce vfio helpers Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 3/9] block: Add VFIO based NVMe driver Fam Zheng
2018-01-12 9:44 ` Stefan Hajnoczi
2018-01-12 11:00 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 4/9] block: Introduce buf register API Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 5/9] block/nvme: Implement .bdrv_(un)register_buf Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 6/9] qemu-img: Map bench buffer Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 7/9] block: Move NVMe constants to a separate header Fam Zheng
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 8/9] docs: Add section for NVMe VFIO driver Fam Zheng
2018-01-12 9:45 ` Stefan Hajnoczi
2018-01-12 8:55 ` [Qemu-devel] [PATCH v5 9/9] qapi: Add NVMe driver options to the schema Fam Zheng
2018-01-12 9:46 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112094619.GC7356@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=keith.busch@intel.com \
--cc=krister@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).