Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 11 Jan 2018 22:13:25 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Jan 11, 2018 at 02:05:20PM +0100, Igor Mammedov wrote:
> > On Wed, 10 Jan 2018 00:39:02 +0800
> > Jay Zhou <jianjay.zhou@huawei.com> wrote:
> > 
> > Jay,
> > considering how non trivial touched code is, would you mind
> > first adding 'make check' testcases for success/failure paths
> > that you are touching?
> > It would help with merging and ensure that future changes to
> > vhost won't break memslots handling.  
> 
> Which tests would you like this to be added to?
At least a test for, so it won't regress unnoticed in future
 1st: [PATCH v5 3/4] vhost: fix memslot limit check
 2nd: limit check failure triggered when DIMM module hotplugged

PS:
It's fine if tests will be another series on top of this one.

> 
> > > v4 -> v5:
> > >   Making the followed up device_add to fall back to userspace
> > >   virtio when netdev_add fails if vhost force flag does not set.
> > > 
> > > Jay Zhou (4):
> > >   vhost: remove assertion to prevent crash
> > >   tap: do not close fd if only vhost failed to initialize
> > >   vhost: fix memslot limit check
> > >   vhost: used_memslots refactoring
> > > 
> > >  hw/virtio/vhost-backend.c         | 15 +++++++-
> > >  hw/virtio/vhost-user.c            | 74 +++++++++++++++++++++++++++------------
> > >  hw/virtio/vhost.c                 | 30 +++++++++-------
> > >  include/hw/virtio/vhost-backend.h |  6 ++--
> > >  net/tap.c                         | 25 +++++++++----
> > >  5 files changed, 104 insertions(+), 46 deletions(-)
> > > 
> > > --
> > > 1.8.3.1
> > > 
> > >