From: Gerd Hoffmann <kraxel@redhat.com>
To: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Cao jin" <caoj.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v3] hw/usb/ccid: Make ccid_card_init() take an error parameter
Date: Fri, 12 Jan 2018 14:19:44 +0100 [thread overview]
Message-ID: <20180112131944.wbdxi2nxv7zqpqeu@sirius.home.kraxel.org> (raw)
In-Reply-To: <a8b7c670cb61b8096291f5730af62f4230a3e7fa.1514187411.git.maozy.fnst@cn.fujitsu.com>
On Mon, Dec 25, 2017 at 03:50:37PM +0800, Mao Zhongyi wrote:
> Replace init() of CCIDCardClass with realize, then convert
> ccid_card_init(), ccid_card_initfn() and it's callbacks to
> take an Error** in ordor to report the error more clearly.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@gmail.com>
> Cc: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> v3:
> add 'qapi/error.h' header file.
>
> hw/usb/ccid-card-emulated.c | 44 +++++++++++++++++++++----------------------
> hw/usb/ccid-card-passthru.c | 12 ++++++------
> hw/usb/ccid.h | 2 +-
> hw/usb/dev-smartcard-reader.c | 34 ++++++++++++++++++---------------
> 4 files changed, 48 insertions(+), 44 deletions(-)
Patch added to queue.
thanks,
Gerd
prev parent reply other threads:[~2018-01-12 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 7:50 [Qemu-devel] [PATCH v3] hw/usb/ccid: Make ccid_card_init() take an error parameter Mao Zhongyi
2017-12-25 8:00 ` no-reply
2018-01-12 13:19 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112131944.wbdxi2nxv7zqpqeu@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=maozy.fnst@cn.fujitsu.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).