From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZzFP-00054P-7S for qemu-devel@nongnu.org; Fri, 12 Jan 2018 08:19:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZzFM-0002PC-0m for qemu-devel@nongnu.org; Fri, 12 Jan 2018 08:19:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41214) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eZzFL-0002NH-Q1 for qemu-devel@nongnu.org; Fri, 12 Jan 2018 08:19:47 -0500 Date: Fri, 12 Jan 2018 14:19:44 +0100 From: Gerd Hoffmann Message-ID: <20180112131944.wbdxi2nxv7zqpqeu@sirius.home.kraxel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] hw/usb/ccid: Make ccid_card_init() take an error parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mao Zhongyi Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Cao jin On Mon, Dec 25, 2017 at 03:50:37PM +0800, Mao Zhongyi wrote: > Replace init() of CCIDCardClass with realize, then convert > ccid_card_init(), ccid_card_initfn() and it's callbacks to > take an Error** in ordor to report the error more clearly. >=20 > Cc: Gerd Hoffmann > Cc: Marc-Andr=E9 Lureau > Cc: Cao jin >=20 > Signed-off-by: Mao Zhongyi > Signed-off-by: Cao jin > --- > v3: > add 'qapi/error.h' header file. >=20 > hw/usb/ccid-card-emulated.c | 44 +++++++++++++++++++++--------------= -------- > hw/usb/ccid-card-passthru.c | 12 ++++++------ > hw/usb/ccid.h | 2 +- > hw/usb/dev-smartcard-reader.c | 34 ++++++++++++++++++--------------- > 4 files changed, 48 insertions(+), 44 deletions(-) Patch added to queue. thanks, Gerd