From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Frediano Ziglio <fziglio@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 3/9] spice: remove QXLWorker interface field
Date: Fri, 12 Jan 2018 15:52:52 +0100 [thread overview]
Message-ID: <20180112145258.10578-4-kraxel@redhat.com> (raw)
In-Reply-To: <20180112145258.10578-1-kraxel@redhat.com>
From: Frediano Ziglio <fziglio@redhat.com>
This fields points to an old interface that is no more
used in the current code.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Message-id: 20171122135625.16625-1-fziglio@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/ui/spice-display.h | 1 -
hw/display/qxl.c | 1 -
ui/spice-display.c | 2 --
3 files changed, 4 deletions(-)
diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h
index aaf2019889..6b5c73b21c 100644
--- a/include/ui/spice-display.h
+++ b/include/ui/spice-display.h
@@ -86,7 +86,6 @@ struct SimpleSpiceDisplay {
DisplayChangeListener dcl;
void *buf;
int bufsize;
- QXLWorker *worker;
QXLInstance qxl;
uint32_t unique;
pixman_image_t *surface;
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 99365c3e8f..b9fa067f6e 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -518,7 +518,6 @@ static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)
PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
trace_qxl_interface_attach_worker(qxl->id);
- qxl->ssd.worker = qxl_worker;
}
static void interface_set_compression_level(QXLInstance *sin, int level)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index ad1ceafb3f..85a72fe76a 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -519,7 +519,6 @@ static void interface_attach_worker(QXLInstance *sin, QXLWorker *qxl_worker)
SimpleSpiceDisplay *ssd = container_of(sin, SimpleSpiceDisplay, qxl);
dprint(1, "%s/%d:\n", __func__, ssd->qxl.id);
- ssd->worker = qxl_worker;
}
static void interface_set_compression_level(QXLInstance *sin, int level)
@@ -1028,7 +1027,6 @@ static void qemu_spice_display_init_one(QemuConsole *con)
ssd->qxl.base.sif = &dpy_interface.base;
qemu_spice_add_display_interface(&ssd->qxl, con);
- assert(ssd->worker);
qemu_spice_create_host_memslot(ssd);
register_displaychangelistener(&ssd->dcl);
--
2.9.3
next prev parent reply other threads:[~2018-01-12 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 14:52 [Qemu-devel] [PULL 0/9] Ui 20180112 patches Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 1/9] input: fix memory leak Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 2/9] ui: deprecate use of GTK 2.x in favour of 3.x series Gerd Hoffmann
2018-01-12 14:52 ` Gerd Hoffmann [this message]
2018-01-12 14:52 ` [Qemu-devel] [PULL 4/9] spice: remove unused watch list Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 5/9] spice: remove only written event_mask field Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 6/9] spice: remove unused timer list Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 7/9] sdl2: Do not hide the cursor on auxilliary windows Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 8/9] sdl2 uses surface relative coordinates Gerd Hoffmann
2018-01-12 14:52 ` [Qemu-devel] [PULL 9/9] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held Gerd Hoffmann
2018-01-15 9:36 ` [Qemu-devel] [PULL 0/9] Ui 20180112 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112145258.10578-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=fziglio@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).