From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Kevin O'Connor" <kevin@koconnor.net>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v7 09/14] sdhci: move MASK_TRNMOD with other SDHC_TRN* defines in "sd-internal.h"
Date: Sat, 13 Jan 2018 02:07:12 -0300 [thread overview]
Message-ID: <20180113050717.22969-10-f4bug@amsat.org> (raw)
In-Reply-To: <20180113050717.22969-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
---
hw/sd/sdhci-internal.h | 1 +
hw/sd/sdhci.c | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index 248fd027f9..e941bc2386 100644
--- a/hw/sd/sdhci-internal.h
+++ b/hw/sd/sdhci-internal.h
@@ -43,6 +43,7 @@
#define SDHC_TRNS_ACMD12 0x0004
#define SDHC_TRNS_READ 0x0010
#define SDHC_TRNS_MULTI 0x0020
+#define SDHC_TRNMOD_MASK 0x0037
/* R/W Command Register 0x0 */
#define SDHC_CMDREG 0x0E
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 7b075f6cb8..e8f4a3478a 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -99,7 +99,6 @@
(SDHC_CAPAB_BASECLKFREQ << 8) | (SDHC_CAPAB_TOUNIT << 7) | \
(SDHC_CAPAB_TOCLKFREQ))
-#define MASK_TRNMOD 0x0037
#define MASKED_WRITE(reg, mask, val) (reg = (reg & (mask)) | (val))
static uint8_t sdhci_slotint(SDHCIState *s)
@@ -1026,7 +1025,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, unsigned size)
if (!(s->capareg & SDHC_CAN_DO_DMA)) {
value &= ~SDHC_TRNS_DMA;
}
- MASKED_WRITE(s->trnmod, mask, value & MASK_TRNMOD);
+ MASKED_WRITE(s->trnmod, mask, value & SDHC_TRNMOD_MASK);
MASKED_WRITE(s->cmdreg, mask >> 16, value >> 16);
/* Writing to the upper byte of CMDREG triggers SD command generation */
--
2.15.1
next prev parent reply other threads:[~2018-01-13 5:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 5:07 [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1) Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 01/14] sdhci: clean up includes Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 02/14] sdhci: remove dead code Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 03/14] sdhci: refactor same sysbus/pci properties into a common one Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 04/14] sdhci: refactor common sysbus/pci class_init() into sdhci_common_class_init() Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 05/14] sdhci: refactor common sysbus/pci realize() into sdhci_common_realize() Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 06/14] sdhci: refactor common sysbus/pci unrealize() into sdhci_common_unrealize() Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 07/14] sdhci: use qemu_log_mask(UNIMP) instead of fprintf() Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 08/14] sdhci: convert the DPRINT() calls into trace events Philippe Mathieu-Daudé
2018-01-13 5:07 ` Philippe Mathieu-Daudé [this message]
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 10/14] sdhci: rename the SDHC_CAPAB register Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 11/14] sdhci: fix CAPAB/MAXCURR registers, both are 64bit and read-only Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 12/14] sdhci: Implement write method of ACMD12ERRSTS register Philippe Mathieu-Daudé
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 13/14] sdhci: fix the PCI device, using the PCI address space for DMA Philippe Mathieu-Daudé
2018-01-15 13:50 ` Peter Maydell
2018-01-13 5:07 ` [Qemu-devel] [PATCH v7 14/14] sdhci: add a 'dma' property to the sysbus devices Philippe Mathieu-Daudé
2018-01-15 13:51 ` [Qemu-devel] [PATCH v7 00/14] SDHCI: housekeeping (part 1) Peter Maydell
2018-01-15 14:04 ` Philippe Mathieu-Daudé
2018-01-15 14:47 ` Peter Maydell
2018-01-15 15:17 ` Philippe Mathieu-Daudé
2018-01-15 16:22 ` Paolo Bonzini
2018-01-15 16:24 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180113050717.22969-10-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@xilinx.com \
--cc=andrew.smirnov@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=kevin@koconnor.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).