qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Eduardo Habkost <ehabkost@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks
Date: Sat, 13 Jan 2018 23:04:09 -0300	[thread overview]
Message-ID: <20180114020412.26160-1-f4bug@amsat.org> (raw)

Hi,

Learning how to implement QOM devices I found the pattern changing parent hooks
when the parent is abstract not trivial to understand.

This series add few helpers to have this pattern more explicit.

Those functions deserve some comments, but before spending more time I'd like
to get some feedbacks if this might be useful or not.
If so, I can split the 3rd patch in many patches for each subsystem maintainers.

This can also be use for the CPUClass->reset() method, dunno if useful but
maybe to be consistent.

Regards,

Phil.

Philippe Mathieu-Daudé (3):
  qdev: rename typedef qdev_resetfn() -> DeviceReset()
  qdev: add helpers to be more explicit when using abstract QOM parent functions
  qdev: use device_class_set_parent_realize/unrealize/reset()

 include/hw/qdev-core.h             | 14 ++++++++++++--
 hw/core/qdev.c                     | 24 ++++++++++++++++++++++++
 hw/i386/kvm/i8254.c                |  4 ++--
 hw/i386/kvm/i8259.c                |  3 +--
 hw/input/adb-kbd.c                 |  4 ++--
 hw/input/adb-mouse.c               |  4 ++--
 hw/intc/arm_gic.c                  |  3 +--
 hw/intc/arm_gic_kvm.c              |  7 +++----
 hw/intc/arm_gicv3.c                |  3 +--
 hw/intc/arm_gicv3_its_kvm.c        |  3 +--
 hw/intc/arm_gicv3_kvm.c            |  7 +++----
 hw/intc/i8259.c                    |  3 +--
 hw/net/vmxnet3.c                   |  4 ++--
 hw/pci-bridge/gen_pcie_root_port.c |  3 +--
 hw/scsi/vmw_pvscsi.c               |  4 ++--
 hw/timer/i8254.c                   |  3 +--
 hw/vfio/amd-xgbe.c                 |  4 ++--
 hw/vfio/calxeda-xgmac.c            |  4 ++--
 hw/virtio/virtio-pci.c             |  4 ++--
 target/alpha/cpu.c                 |  4 ++--
 target/arm/cpu.c                   |  4 ++--
 target/cris/cpu.c                  |  4 ++--
 target/hppa/cpu.c                  |  4 ++--
 target/i386/cpu.c                  |  8 ++++----
 target/lm32/cpu.c                  |  5 ++---
 target/m68k/cpu.c                  |  5 ++---
 target/microblaze/cpu.c            |  5 ++---
 target/mips/cpu.c                  |  5 ++---
 target/moxie/cpu.c                 |  5 ++---
 target/nios2/cpu.c                 |  4 ++--
 target/openrisc/cpu.c              |  5 ++---
 target/ppc/translate_init.c        |  8 ++++----
 target/s390x/cpu.c                 |  4 ++--
 target/sh4/cpu.c                   |  4 ++--
 target/sparc/cpu.c                 |  4 ++--
 target/tilegx/cpu.c                |  4 ++--
 target/tricore/cpu.c               |  4 ++--
 target/unicore32/cpu.c             |  4 ++--
 target/xtensa/cpu.c                |  4 ++--
 39 files changed, 109 insertions(+), 90 deletions(-)

-- 
2.15.1

             reply	other threads:[~2018-01-14  2:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14  2:04 Philippe Mathieu-Daudé [this message]
2018-01-14  2:04 ` [Qemu-devel] [RFC PATCH 1/3] qdev: rename typedef qdev_resetfn() -> DeviceReset() Philippe Mathieu-Daudé
2018-01-15  9:45   ` Laurent Vivier
2018-01-14  2:04 ` [Qemu-devel] [RFC PATCH 2/3] qdev: add helpers to be more explicit when using abstract QOM parent functions Philippe Mathieu-Daudé
2018-01-15  9:41   ` Laurent Vivier
2018-01-14  2:04 ` [Qemu-devel] [RFC PATCH 3/3] qdev: use device_class_set_parent_realize/unrealize/reset() Philippe Mathieu-Daudé
2018-01-15  1:42   ` David Gibson
2018-01-15  9:09   ` [Qemu-devel] [qemu-s390x] " Cornelia Huck
2018-01-15  9:35   ` [Qemu-devel] " Laurent Vivier
2018-01-15  9:48   ` Marcel Apfelbaum
2018-01-15 11:08 ` [Qemu-devel] [RFC PATCH 0/3] add helpers to be more explicit when using QOM abstract parent hooks Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180114020412.26160-1-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).